Refine logic in WalkerResult

AlmarAubel · AlmarAubel · commit c0bc7138a8c0 · 2024-03-22T16:08:12.000+01:00
The ternary condition inside the CorrectUsage property in WalkerResult.cs has been adjusted. The change ensures that the property correctly combines conditions for CheckedFailure, termination, and non-use of "AccessedValue".
diff --git a/CSharpFunctionalExtensions.Analyzers/UseResultValueWithoutCheck/WalkerResult.cs b/CSharpFunctionalExtensions.Analyzers/UseResultValueWithoutCheck/WalkerResult.cs
@@ -8,7 +8,7 @@ internal class WalkerResult
 
     public bool CorrectUsage =>
         (AccessedValue && CheckResult == CheckResult.CheckedSuccess) || 
-        (CheckResult == CheckResult.CheckedFailure && Terminated || !AccessedValue);
+        (CheckResult == CheckResult.CheckedFailure && Terminated && !AccessedValue);
 
     public void Reset()
     {

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ internal class WalkerResult`
`8`	`8`
`9`	`9`	`public bool CorrectUsage =>`
`10`	`10`	`(AccessedValue && CheckResult == CheckResult.CheckedSuccess) \|\|`
`11`		`- (CheckResult == CheckResult.CheckedFailure && Terminated \|\| !AccessedValue);`
	`11`	`+ (CheckResult == CheckResult.CheckedFailure && Terminated && !AccessedValue);`
`12`	`12`
`13`	`13`	`public void Reset()`
`14`	`14`	`{`