Fix/issue-244-code-cleanup#246
Merged
XingerTang merged 1 commit intoApr 21, 2026
Merged
Conversation
Contributor
Author
|
New help message: |
Contributor
Author
|
Docs change preview: https://xingertang-alphapeel.readthedocs.io/en/latest/usage.html |
gregorgorjanc
left a comment
Member
There was a problem hiding this comment.
Good job @XingerTang. I left some minor comments and actions for you to follow on.
Member
There was a problem hiding this comment.
Suggested change
| Map file for loci in the segregation probabilities file | |
| (:ref:`see format details <map_file_format>`). |
gregorgorjanc
approved these changes
Apr 20, 2026
gregorgorjanc
left a comment
Member
There was a problem hiding this comment.
Looks good @XingerTang. Apply the suggested edit for seg_map_file and merge;)
7 tasks
c9aee98 to
c2728e3
Compare
c2728e3 to
34585c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #244
What changed
See #244
Why this change
See #244
Submodule changes
Notes / Risks
develbranch before merge