Feat/issue-255-add-ser-per#256
Merged
XingerTang merged 1 commit intoApr 30, 2026
Merged
Conversation
gregorgorjanc
requested changes
Apr 29, 2026
gregorgorjanc
left a comment
gregorgorjanc
left a comment
Member
There was a problem hiding this comment.
See the above comments @XingerTang
XingerTang
force-pushed
the
feat/issue-255-add-ser-per
branch
from
c0a35e6 to
e4a60ae
Compare
| help="Enter the path of the true haplotype file, default is the simulation path", | ||
| ) | ||
| parser.add_argument( | ||
| "-file_name", |
Member
There was a problem hiding this comment.
Apologies for being a pest, but shouldn't this be -called_path or similar (-called_file), to match the -true_path or similar (-true_file)?
Contributor
Author
There was a problem hiding this comment.
You are right, consistency is important.
gregorgorjanc
approved these changes
Apr 29, 2026
gregorgorjanc
left a comment
gregorgorjanc
left a comment
Member
There was a problem hiding this comment.
Looks good now @XingerTang! Merge time;)
XingerTang
force-pushed
the
feat/issue-255-add-ser-per
branch
from
a8106a4 to
bcd9656
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #255
What changed
utils.pyWhy this change
See #255
Notes / Risks