Refactor minor fixes#275
Merged
Merged
Conversation
| The first value in each line is the individual ID. | ||
| The remaining values are genotype probabilities at each locus. | ||
|
|
||
| When working with the X chromosome for male individual, the first line and |
Member
There was a problem hiding this comment.
This won’t be clear to most as it’s too cryptic.
I suggest the following.
- Take the X example input from the above (there id1 and id3 are males…)
- Get genotype probabilities for the example
- Create a separate output example for the X chromosome below the autosomal chromosome
- Add this text above that example
- Mention that for females the interpretation is as for an autosomal chromosome below, but for males …
I will then suggest edits
gregorgorjanc
requested changes
May 30, 2026
gregorgorjanc
left a comment
Member
There was a problem hiding this comment.
@XingerTang nice that you are polishing these bits! Great! I have suggested some improvements for documenting X chr genotype probability output
| id4 0.0001 0.0001 0.9999 0.0000 | ||
| id4 0.0000 0.9999 0.0000 0.0000 | ||
|
|
||
| When working with the X chromosome, for female individual, the interpretation |
Member
There was a problem hiding this comment.
Suggested change
| When working with the X chromosome, for female individual, the interpretation | |
| When working with the X chromosome, for a female individual, the interpretation |
| id4 0.0000 0.9999 0.0000 0.0000 | ||
|
|
||
| When working with the X chromosome, for female individual, the interpretation | ||
| is as for an autosomal chromosome above. For male individual, the first line and |
Member
There was a problem hiding this comment.
Suggested change
| is as for an autosomal chromosome above. For male individual, the first line and | |
| is as for an autosomal chromosome above. For a male individual, the first line and |
|
|
||
| When working with the X chromosome, for female individual, the interpretation | ||
| is as for an autosomal chromosome above. For male individual, the first line and | ||
| the last line corresponding to ``a`` and ``A`` respectively, with the middle |
Member
There was a problem hiding this comment.
Suggested change
| the last line corresponding to ``a`` and ``A`` respectively, with the middle | |
| the last line respectively correspond to ``a`` and ``A`` genotypes, with the middle |
| id4 0.0000 0.0000 0.7088 0.0000 | ||
| id4 0.0000 0.9999 0.0000 0.0000 | ||
|
|
||
| When working with the X chromosome, for female individual, the interpretation |
Member
There was a problem hiding this comment.
Apply the same edits as above
gregorgorjanc
requested changes
May 30, 2026
gregorgorjanc
left a comment
Member
There was a problem hiding this comment.
Minor edits and we merge this in
4da04e4 to
e4afeb3
Compare
gregorgorjanc
approved these changes
Jun 1, 2026
gregorgorjanc
left a comment
Member
There was a problem hiding this comment.
Merge-away @XingerTang ;) Yay.
Member
|
Aha, I assume you squash and merge. |
d6d7b8d to
7a37353
Compare
Contributor
Author
|
Great. Squash done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
methodoptionalt_allele_proboptionWhy this change
methoddoes not have a default value while parsing the arguments, but if there is no input for the option, then the program would run in themultimode. We can see it as equivalent to having a default value ofmulti.alt_allele_probwon't give posterior alternative allele probabilities; other options that prompt outputs either give the posterior probabilities, such asseg_prob,hap, or will warn the user during the run, such aspheno_penetrance_prob. Therefore, it is worth noting.Notes / Risks