Task/4 2 2026 1027 plotting with just one color - #1691
Conversation
… format. Also adding additional validator constructs needed to complete this.
…2025-json-schema-for-filters
…2025-json-schema-for-filters
(Also fixing a bug in the dray rendering filter :( )
Signed-off-by: Emily Howell <howell31@llnl.gov>
…ocs to build locally and now I should actually make them look right too
…ition' of github.com:Alpine-DAV/ascent into task/4_2_2026-1027-plotting-with-just-one-color
…ition' of github.com:Alpine-DAV/ascent into task/4_2_2026-1027-plotting-with-just-one-color
…2026-1027-plotting-with-just-one-color
|
@cyrus All of the dependencies for this branch are merged in. This should be ready for review now |
cyrush
left a comment
There was a problem hiding this comment.
This looks good!
Users would also like to be able to create these style plots w/o a field.
s1:
plots:
p1:
type: "mesh"
topology: "mytopo" # optional, needed if mutiple topos exist
color_table:
solid: [0.0, .184, .655]
We should add an option to the interface that allows a solid color mesh plot.
This will require plumbing behind the scenes, maybe it is realized as a pc plot with a dummy field.
Side note:
We should also consider accepting hex style colors since those are ubiquitous vs floating point style colors. Let's add a separate ticket for this,.
…2026-1027-plotting-with-just-one-color
There was a problem hiding this comment.
We actually want this case to look exactly like the solid case.
The idea is a colored plot of the surface without having identify or know about any of the fields.
There was a problem hiding this comment.
Sorry, I just assumed that you wanted this to just be a colored version of the mesh plot that is produced. Do you want a different backend to reroute this?
There was a problem hiding this comment.
Yes, I think we need to do something behind the scenes to make this work transparently for the user.
There was a problem hiding this comment.
Okay, I added another test this time that does pseudo color plots without input fields.
|
we discussed and agreed that pseudocolor accepts a color table with a single color and no field is the best way to expose this to users. |
|
We can also discuss aliases for plot types, here are some ideas: |
…hub.com:Alpine-DAV/ascent into task/4_2_2026-1027-plotting-with-just-one-color
cyrush
left a comment
There was a problem hiding this comment.
Looks good, thanks for getting the details ironed out!
Implemented for both VTK-H and Devil Ray rendering. I took two different approaches. The implementation in the Devil Ray parsing builds a color_table with the one color and passes it to parse color table, the other just sets the color table directly. Curious which is prefered.
Also, I built this on top of the Json Schema changes. I figured it was easier to implement the changes to the parameter checking there then to have to update them later.