Skip to content

Task/4 2 2026 1027 plotting with just one color - #1691

Merged
emily-howell merged 120 commits into
developfrom
task/4_2_2026-1027-plotting-with-just-one-color
Aug 4, 2026
Merged

Task/4 2 2026 1027 plotting with just one color#1691
emily-howell merged 120 commits into
developfrom
task/4_2_2026-1027-plotting-with-just-one-color

Conversation

@emily-howell

@emily-howell emily-howell commented Apr 7, 2026

Copy link
Copy Markdown
Member

Implemented for both VTK-H and Devil Ray rendering. I took two different approaches. The implementation in the Devil Ray parsing builds a color_table with the one color and passes it to parse color table, the other just sets the color table directly. Curious which is prefered.

Also, I built this on top of the Json Schema changes. I figured it was easier to implement the changes to the parameter checking there then to have to update them later.

… format. Also adding additional validator constructs needed to complete this.
(Also fixing a bug in the dray rendering filter :( )
Signed-off-by: Emily Howell <howell31@llnl.gov>
@emily-howell

Copy link
Copy Markdown
Member Author

@cyrus All of the dependencies for this branch are merged in. This should be ready for review now

@cyrush cyrush left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Users would also like to be able to create these style plots w/o a field.

s1:
  plots:
     p1:
       type: "mesh"
       topology: "mytopo" # optional, needed if mutiple topos exist
       color_table:
           solid: [0.0, .184, .655]

We should add an option to the interface that allows a solid color mesh plot.

This will require plumbing behind the scenes, maybe it is realized as a pc plot with a dummy field.

Side note:
We should also consider accepting hex style colors since those are ubiquitous vs floating point style colors. Let's add a separate ticket for this,.

Comment thread src/docs/sphinx/Actions/Scenes.rst Outdated
Comment thread src/tests/ascent/t_ascent_dray.cpp

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually want this case to look exactly like the solid case.

The idea is a colored plot of the surface without having identify or know about any of the fields.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just assumed that you wanted this to just be a colored version of the mesh plot that is produced. Do you want a different backend to reroute this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we need to do something behind the scenes to make this work transparently for the user.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I added another test this time that does pseudo color plots without input fields.

@cyrush

cyrush commented Jul 21, 2026

Copy link
Copy Markdown
Member

we discussed and agreed that pseudocolor accepts a color table with a single color and no field is the best way to expose this to users.

@cyrush

cyrush commented Jul 27, 2026

Copy link
Copy Markdown
Member

We can also discuss aliases for plot types, here are some ideas:

wireframe ==> mesh
surface ==> pseudocolor with a single color

@cyrush
cyrush requested a review from nicolemarsaglia July 30, 2026 21:29

@nicolemarsaglia nicolemarsaglia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cyrush cyrush left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for getting the details ironed out!

@emily-howell
emily-howell merged commit 2d15bfe into develop Aug 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants