Task/7 20 2026 hex color code support - #1749
Merged
Merged
Conversation
… format. Also adding additional validator constructs needed to complete this.
…2025-json-schema-for-filters
…2025-json-schema-for-filters
(Also fixing a bug in the dray rendering filter :( )
Signed-off-by: Emily Howell <howell31@llnl.gov>
…2026-1027-plotting-with-just-one-color
…hub.com:Alpine-DAV/ascent into task/7_20_2026-hex-ccolor-code-support
emily-howell
changed the title
…hub.com:Alpine-DAV/ascent into task/7_20_2026-hex-ccolor-code-support
…hub.com:Alpine-DAV/ascent into task/4_2_2026-1027-plotting-with-just-one-color
…hub.com:Alpine-DAV/ascent into task/7_20_2026-hex-ccolor-code-support
Member
Author
|
@cyrush @nicolemarsaglia I think this is in a much more complete state now. The original MR just had support for hex with solid colors but now it works with all of the different color table formats. I also added a bunch of documentation and tests. Let me know what you think :) |
Base automatically changed from
task/4_2_2026-1027-plotting-with-just-one-color
to
develop
August 4, 2026 16:54
…_2026-hex-ccolor-code-support
cyrush
approved these changes
Aug 5, 2026
cyrush
left a comment
cyrush
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks for this addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.