This repository was archived by the owner on Jul 14, 2022. It is now read-only.
Streamlines from vtkm #197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particle add
Collaborator
Author
|
@mclarsen any idea on why this is hanging? I click on the running test and I'm not seeing anything helpful. |
Member
|
Building vtkm / h with cuda inside a docker container takes a ridiculously long time. Everything is 'normal'. |
Member
|
Also, we don't expect that the vtkm contour tree code passes, so the board is green to me |
mclarsen
approved these changes
Feb 17, 2021
Member
mclarsen
left a comment
mclarsen
left a comment
There was a problem hiding this comment.
Question I have
- how are you handling the temporal element of streamlines?
- Are you setting the vtkm communicator based on what vtkh has?
Collaborator
Author
|
1. This is steady state only.
2. No, I'm not.... I forgot about that. I'll look at how other filters
handle this.
…On Tue, Feb 16, 2021 at 7:31 PM Matt Larsen ***@***.***> wrote:
***@***.**** approved this pull request.
Question I have
1. how are you handling the temporal element of streamlines?
2. Are you setting the vtkm communicator based on what vtkh has?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#197 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPIXQLEKWSCBJ6T5BZLNS3S7ME7XANCNFSM4XRDZXNA>
.
|
mclarsen
reviewed
Feb 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the mpi-enabled filters in VTKm.