Skip to content

Fix COLLAPSING_MERGE_TREE Update statement #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix COLLAPSING_MERGE_TREE Update statement #74

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f559e2
Fix COLLAPSING_MERGE_TREE `Update` statement
Raffaellorr Sep 9, 2022
bc2f768
fix typo `beforeInserted`
Raffaellorr Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/java/com/altinity/clickhouse/sink/connector/db/DbWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ public BlockMetaData addToPreparedStatementBatch(String topicName, Map<MutablePa
try (PreparedStatement ps = this.conn.prepareStatement(insertQuery)) {

List<ClickHouseStruct> recordsList = entry.getValue();
boolean beforeInserted = false;
for (ClickHouseStruct record : recordsList) {
try {
bmd.update(record);
Expand All @@ -418,9 +419,15 @@ public BlockMetaData addToPreparedStatementBatch(String topicName, Map<MutablePa
insertPreparedStatement(entry.getKey().right, ps, record.getAfterModifiedFields(), record, record.getAfterStruct(), false);
} else if(CdcRecordState.CDC_RECORD_STATE_BOTH == getCdcSectionBasedOnOperation(record.getCdcOperation())) {
if(this.engine != null && this.engine.getEngine().equalsIgnoreCase(DBMetadata.TABLE_ENGINE.COLLAPSING_MERGE_TREE.getEngine())) {
insertPreparedStatement(entry.getKey().right, ps, record.getBeforeModifiedFields(), record, record.getBeforeStruct(), true);
if (!beforeInseted) {
Copy link
Collaborator

@subkanthi subkanthi Sep 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, This should be beforeInserted

Copy link
Author

@Raffaellorr Raffaellorr Sep 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. I'll fix it.

insertPreparedStatement(entry.getKey().right, ps, record.getBeforeModifiedFields(), record, record.getBeforeStruct(), true);
} else {
insertPreparedStatement(entry.getKey().right, ps, record.getAfterModifiedFields(), record, record.getAfterStruct(), false);
}
beforeInseted = !beforeInseted;
} else {
insertPreparedStatement(entry.getKey().right, ps, record.getAfterModifiedFields(), record, record.getAfterStruct(), false);
}
insertPreparedStatement(entry.getKey().right, ps, record.getAfterModifiedFields(), record, record.getAfterStruct(), false);
} else {
log.error("INVALID CDC RECORD STATE");
}
Expand Down