Skip to content

Change page titles according to agreed titles with Design - #2260

Merged
mgunnerud merged 4 commits into
mainfrom
fix/3228-sidetitler-pa-tilgangstyring
Jun 1, 2026
Merged

Change page titles according to agreed titles with Design#2260
mgunnerud merged 4 commits into
mainfrom
fix/3228-sidetitler-pa-tilgangstyring

Conversation

@mgunnerud

@mgunnerud mgunnerud commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description

  • Change several page titles

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • New Features

    • Page titles now display contextually (including inbox deeplink handling) and are set consistently across pages and error flows.
    • Headings updated to use unified reportee-aware heading components.
  • Bug Fixes

    • Corrected several pages to use the appropriate translation keys for titles.
  • Style

    • Updated page header and layout styles for administration, maskinporten, and settings pages.

Review Change Stack

@mgunnerud mgunnerud linked an issue May 28, 2026 that may be closed by this pull request
@github-actions github-actions Bot added bugfix kind/bug Used when something isn't working labels May 28, 2026
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@mgunnerud, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 37 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ffa1f254-f332-4885-a2ef-10888f62945b

📥 Commits

Reviewing files that changed from the base of the PR and between f8a8f70 and 1282c5b.

📒 Files selected for processing (3)
  • src/localizations/en.json
  • src/localizations/no_nb.json
  • src/localizations/no_nn.json
📝 Walkthrough

Walkthrough

Standardizes browser document titles across AM UI pages and error screens by calling useDocumentTitle with updated i18n keys; localization files (en, no_nb, no_nn) were updated to provide the new titles.

Changes

Document Title Standardization

Layer / File(s) Summary
Feature page document title updates
src/features/amUI/InstanceDetailPage/InstanceDetailPage.tsx, src/features/amUI/agentDetails/AgentDetailsPage.tsx, src/features/amUI/clientDetails/ClientDetailsPage.tsx, src/features/amUI/packagePoaDetailsPage/PackagePoaDetails.tsx, src/features/amUI/reporteeRightsPage/ReporteeRightsPage.tsx, src/features/amUI/systemUser/SystemUserDetailPage/SystemUserDetailsPage.tsx
Agent, client, reportee rights, and system user detail pages update their title translation keys; InstanceDetailPage conditionally selects between inbox and standard titles; access package page sets title including fetched package name.
Error page document title setup
src/sites/ErrorPage/amUi/ErrorPage.tsx, src/sites/ErrorPage/amUi/ReporteeChangeErrorPage.tsx, src/sites/ErrorPage/amUi/contents/PageNotFound.tsx
Error, reportee-change, and 404 pages call useDocumentTitle with translated error_page keys.
Client administration header markup & CSS
src/features/amUI/clientAdministration/ClientAdministrationPageContent.tsx, src/features/amUI/clientAdministration/ClientAdministrationPageContent.module.css
Removed header-specific CSS classes and simplified header wrapper to a plain div while preserving ReporteePageHeading props.
Maskinporten page heading and data fetch
src/features/amUI/maskinporten/MaskinportenPage.tsx, src/features/amUI/maskinporten/MaskinportenPage.module.css
Replaced DsHeading with ReporteePageHeading, added useGetReporteeQuery, and removed unused header CSS/import.
Settings layout and CSS adjustments
src/features/amUI/settings/SettingsPageContent.tsx, src/features/amUI/settings/SettingsPageContent.module.css
Replaced .pageContent usage with .notAdminAlert for non-admin and removed pageContent styling for admin render; added spacing adjustments.
English localization
src/localizations/en.json
Updated page title strings for errors, users, rights, client admin agent/client pages, system user pages, consent request, instance detail (including inbox variant), and package POA titles.
Norwegian Bokmål localization
src/localizations/no_nb.json
Added/updated Bokmål translations for the same set of page title keys and headings (including instance inbox/document variants).
Norwegian Nynorsk localization
src/localizations/no_nn.json
Added/updated Nynorsk translations mirroring the English/Bokmål title changes and added error page title key.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • sonwit
  • allinox

Poem

Titles set with care and light,
Languages lined up just right,
Pages whisper names concise,
Error screens and headings nice,
Browser tabs now sing at night.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating page titles across multiple components to align with design-approved titles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/3228-sidetitler-pa-tilgangstyring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/localizations/en.json`:
- Line 186: The English locale key error_page.reportee_change_error.page_title
currently contains Norwegian text ("Feilside - Altinn"); update that value to an
English page title (e.g., "Error page - Altinn" or "Error - Altinn") so English
users see a consistent English browser title for the reportee change error page.

In `@src/localizations/no_nb.json`:
- Line 714: Update the value for the localization key "agent_page_title" to use
the Norwegian Bokmål compound noun by replacing "Bruker med klient tilgang -
Altinn" with "Bruker med klienttilgang - Altinn"; locate the key
"agent_page_title" in src/localizations/no_nb.json and update only the string
value to the corrected wording.

In `@src/localizations/no_nn.json`:
- Around line 714-715: The Nynorsk localization keys agent_page_title and
client_page_title use Bokmål/incorrect spacing; update their values so
agent_page_title reads "Brukar med klienttilgang - Altinn" (remove space in
"klienttilgang") and client_page_title reads "Vald klient - Altinn" (use "Vald"
instead of "Valgt"), leaving the keys unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cc664dae-47b3-4a27-a77f-4ae3303c5b73

📥 Commits

Reviewing files that changed from the base of the PR and between 4075e5d and d542cb3.

📒 Files selected for processing (12)
  • src/features/amUI/InstanceDetailPage/InstanceDetailPage.tsx
  • src/features/amUI/agentDetails/AgentDetailsPage.tsx
  • src/features/amUI/clientDetails/ClientDetailsPage.tsx
  • src/features/amUI/packagePoaDetailsPage/PackagePoaDetails.tsx
  • src/features/amUI/reporteeRightsPage/ReporteeRightsPage.tsx
  • src/features/amUI/systemUser/SystemUserDetailPage/SystemUserDetailsPage.tsx
  • src/localizations/en.json
  • src/localizations/no_nb.json
  • src/localizations/no_nn.json
  • src/sites/ErrorPage/amUi/ErrorPage.tsx
  • src/sites/ErrorPage/amUi/ReporteeChangeErrorPage.tsx
  • src/sites/ErrorPage/amUi/contents/PageNotFound.tsx

Comment thread src/localizations/en.json Outdated
Comment thread src/localizations/no_nb.json Outdated
Comment thread src/localizations/no_nn.json Outdated
@mgunnerud
mgunnerud requested review from allinox and sonwit May 28, 2026 15:11
@mgunnerud
mgunnerud merged commit 98637e2 into main Jun 1, 2026
5 checks passed
@mgunnerud
mgunnerud deleted the fix/3228-sidetitler-pa-tilgangstyring branch June 1, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix kind/bug Used when something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidetitler på tilgangstyring

2 participants