Change page titles according to agreed titles with Design - #2260
Conversation
|
Warning Review limit reached
More reviews will be available in 53 minutes and 37 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughStandardizes browser document titles across AM UI pages and error screens by calling useDocumentTitle with updated i18n keys; localization files (en, no_nb, no_nn) were updated to provide the new titles. ChangesDocument Title Standardization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/localizations/en.json`:
- Line 186: The English locale key error_page.reportee_change_error.page_title
currently contains Norwegian text ("Feilside - Altinn"); update that value to an
English page title (e.g., "Error page - Altinn" or "Error - Altinn") so English
users see a consistent English browser title for the reportee change error page.
In `@src/localizations/no_nb.json`:
- Line 714: Update the value for the localization key "agent_page_title" to use
the Norwegian Bokmål compound noun by replacing "Bruker med klient tilgang -
Altinn" with "Bruker med klienttilgang - Altinn"; locate the key
"agent_page_title" in src/localizations/no_nb.json and update only the string
value to the corrected wording.
In `@src/localizations/no_nn.json`:
- Around line 714-715: The Nynorsk localization keys agent_page_title and
client_page_title use Bokmål/incorrect spacing; update their values so
agent_page_title reads "Brukar med klienttilgang - Altinn" (remove space in
"klienttilgang") and client_page_title reads "Vald klient - Altinn" (use "Vald"
instead of "Valgt"), leaving the keys unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cc664dae-47b3-4a27-a77f-4ae3303c5b73
📒 Files selected for processing (12)
src/features/amUI/InstanceDetailPage/InstanceDetailPage.tsxsrc/features/amUI/agentDetails/AgentDetailsPage.tsxsrc/features/amUI/clientDetails/ClientDetailsPage.tsxsrc/features/amUI/packagePoaDetailsPage/PackagePoaDetails.tsxsrc/features/amUI/reporteeRightsPage/ReporteeRightsPage.tsxsrc/features/amUI/systemUser/SystemUserDetailPage/SystemUserDetailsPage.tsxsrc/localizations/en.jsonsrc/localizations/no_nb.jsonsrc/localizations/no_nn.jsonsrc/sites/ErrorPage/amUi/ErrorPage.tsxsrc/sites/ErrorPage/amUi/ReporteeChangeErrorPage.tsxsrc/sites/ErrorPage/amUi/contents/PageNotFound.tsx
…eadcrumb and heading spacing
…unify breadcrumb and heading spacing" This reverts commit f8a8f70.
Description
Related Issue(s)
Verification
Documentation
Summary by CodeRabbit
New Features
Bug Fixes
Style