Feat/2428 503 on socket exception - #2429
Merged
Merged
Conversation
Socket exceptions towards the downstream authentication API previously bubbled up as unhandled exceptions and were reported as 500, which e2e tests cannot retry on. Approve of system user requests now maps socket errors to a new AMUI-00100 problem with 503 Service Unavailable. Refs #2428
github-actions
Bot
added
the
kind/feature-request
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sonar flagged the test helper for returning ISystemUserRequestClient where the concrete SystemUserRequestClient is known, which costs an interface dispatch per call. The interface using is no longer needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
mgunnerud
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.