Skip to content

Vis «Lukk» i stedet for «Avbryt» når det ikke er ulagrede endringer i varslingsadresse-modalen - #2433

Merged
sonwit merged 1 commit into
mainfrom
cancel-button-in-settings-modal-fix
Aug 20, 2026
Merged

Vis «Lukk» i stedet for «Avbryt» når det ikke er ulagrede endringer i varslingsadresse-modalen#2433
sonwit merged 1 commit into
mainfrom
cancel-button-in-settings-modal-fix

Conversation

@sonwit

@sonwit sonwit commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Etter lagring av e-post-/SMS-adresser under Innstillinger sto det fortsatt «Avbryt» på sekundærknappen, selv om det ikke lenger var noe å avbryte. Knappen viser nå «Avbryt» når det finnes ulagrede endringer (isChanges, samme flagg som aktiverer «Lagre endringer») og «Lukk» ellers. Gjelder både e-post- og SMS-modalen.

Related Issue(s)

Altinn/altinn-authorization-tmp#2949

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@sonwit, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 171229c2-f0d7-4938-98ea-732481082fbe

📥 Commits

Reviewing files that changed from the base of the PR and between bb8baee and 2fcc32a.

📒 Files selected for processing (1)
  • src/features/amUI/settings/SettingsModal.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonwit
sonwit requested a review from allinox August 19, 2026 10:50

@allinox allinox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅✅✅✅✅✅✅✅✅✅✅✅✅✅

@sonwit
sonwit merged commit d6fc63d into main Aug 20, 2026
6 checks passed
@sonwit
sonwit deleted the cancel-button-in-settings-modal-fix branch August 20, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants