Skip to content

Instans-delegering "fullmakt -> delt fullmakt" - #2434

Merged
sonwit merged 1 commit into
mainfrom
change-user-poa-text-on-instance-delegation-page
Aug 20, 2026
Merged

Instans-delegering "fullmakt -> delt fullmakt"#2434
sonwit merged 1 commit into
mainfrom
change-user-poa-text-on-instance-delegation-page

Conversation

@sonwit

@sonwit sonwit commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

  • Tom-tilstand: «Ingen brukere har tilgang.» → «Ingen brukere med delt fullmakt»
  • Overskrift ved søk, direkte-lista: «Brukere med fullmakt» → «Brukere med delt fullmakt»
  • Overskrift ved søk, indirekte-lista: «Brukere uten fullmakt» → «Brukere uten delt fullmakt»
1-ingen-brukere 3-sok-brukere-med-delt-fullmakt 4-sok-brukere-uten-delt-fullmakt

«Brukere uten delt fullmakt» er ikke nevnt i issuen, men lagt til for konsistens med den nye overskriften – si fra om den skal være noe annet.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 519847cf-baa1-4d4d-bcbd-63127919d3f9

📥 Commits

Reviewing files that changed from the base of the PR and between bb8baee and 20f4221.

📒 Files selected for processing (5)
  • src/features/amUI/InstanceDetailPage/InstanceUsersAsAdmin.tsx
  • src/features/amUI/InstanceDetailPage/InstanceUsersAsInstanceAdmin.tsx
  • src/localizations/en.json
  • src/localizations/no_nb.json
  • src/localizations/no_nn.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change adds translated headings for direct and indirect user connections in two admin views. It updates English, Norwegian Bokmål, and Norwegian Nynorsk localization strings for shared delegation labels and empty states.

Changes

Shared access labels

Layer / File(s) Summary
User search headings and localization
src/features/amUI/InstanceDetailPage/*.tsx, src/localizations/*.json
The admin views pass translated direct and indirect connection headings to UserSearch. Localization strings now distinguish shared delegation states and update the empty-state messages.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 20f42

This PR updates the wording for delegated access consistently across the affected views and translations. No actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

Suggested labels: Text

Suggested reviewers: mgunnerud

Poem

Direct paths named,
Indirect paths now shine clear,
Empty states speak true.
Three tongues carry the change,
User lists find their labels.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the change from general power of attorney to shared power of attorney on the instance delegation page.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch change-user-poa-text-on-instance-delegation-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonwit
sonwit requested a review from allinox August 19, 2026 10:49

@allinox allinox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synes det er riktig å også legge inn "delt fullmakt" på listen over de som ikke har fullmakten, for å være konsekvente 😊

Er spent på å se om denne tekstendringen vil ha noen påvirkning da, for jeg er litt usikker på om det faktisk vil oppklare noe for brukerne som til nå har vært forvirret - men vi får se! 🤞

@sonwit
sonwit merged commit 85b410b into main Aug 20, 2026
6 checks passed
@sonwit
sonwit deleted the change-user-poa-text-on-instance-delegation-page branch August 20, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants