Sjekk token og redirect til innlogging når et kall gir 401 - #2435
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (23)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR centralizes token refresh and login URL handling, adds shared RTK Query base-query behavior for 401 responses, migrates feature APIs to the shared helper, adds tests, and removes the unused ChangesAuthentication request flow
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The change centralizes 401 handling and token refresh behavior across API calls; no actionable merge-blocking risk remains based on the available evidence. Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant RTKQuery
participant createBaseQuery
participant refreshToken
participant AuthenticationEndpoint
participant Browser
RTKQuery->>createBaseQuery: execute API request
createBaseQuery-->>RTKQuery: return 401 result
createBaseQuery->>refreshToken: refreshToken()
refreshToken->>AuthenticationEndpoint: send refresh request
AuthenticationEndpoint-->>refreshToken: return refresh response
refreshToken->>Browser: redirect to login URL when invalid
createBaseQuery-->>RTKQuery: return original request result
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Når et API-kall svarer 401 (f.eks. brukeren har logget ut i en annen fane) sjekker vi nå tokenet via
authentication/refreshfør feilen sendes videre:basert på eksempel fra RTK sin dokumentasjon her https://redux-toolkit.js.org/rtk-query/usage/customizing-queries#automatic-re-authorization-by-extending-fetchbasequery
axiosble kun brukt i RefreshToken, så den er også fjernet.Related Issue(s)
Altinn/altinn-authorization-tmp#3643
Verification
Documentation
Summary by CodeRabbit
New Features
Bug Fixes
Tests