Update Altinn.Register.Contracts to 1.7.0 - #2102
Merged
Merged
Conversation
In 1.7.0 the Register API's externalUrn is exposed as a typed Party.ExternalUrn property. It therefore no longer lands in JsonExtensionData, which is where PartyExtensions.GetExternalUrn() read it from. Read the typed property instead. The typed value is a FieldValue<NonExhaustive<PartyExternalRefUrn>>, so URN schemes unknown to the package still round-trip verbatim and no behaviour is lost. Without this change the API-provided URN is silently dropped: Person, Organization and SelfIdentifiedUser fall through to the derived-URN construction, and SystemUser — which has no derived path — returns null. The existing tests did not guard this, since the derived URN happens to match the API value for the common party types. Added two tests that separate the code paths: one where the API URN deliberately differs from what would be derived, and one asserting an unknown URN scheme survives. Closes #2072 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mSunberg
added
the
kind/chore
Ceredron
pushed a commit
that referenced
this pull request
Aug 20, 2026
In 1.7.0 the Register API's externalUrn is exposed as a typed Party.ExternalUrn property. It therefore no longer lands in JsonExtensionData, which is where PartyExtensions.GetExternalUrn() read it from. Read the typed property instead. The typed value is a FieldValue<NonExhaustive<PartyExternalRefUrn>>, so URN schemes unknown to the package still round-trip verbatim and no behaviour is lost. Without this change the API-provided URN is silently dropped: Person, Organization and SelfIdentifiedUser fall through to the derived-URN construction, and SystemUser — which has no derived path — returns null. The existing tests did not guard this, since the derived URN happens to match the API value for the common party types. Added two tests that separate the code paths: one where the API URN deliberately differs from what would be derived, and one asserting an unknown URN scheme survives. Closes #2072 Co-authored-by: Martin Todorov <> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1.7.0, externalUrn became a typed property on Party, so it no longer lands in JsonExtensionData where GetExternalUrn() read it from. This reads the typed property instead.
Without the fix, the API-provided URN is silently dropped: Person, Organization and SelfIdentifiedUser fall back to a derived URN, while SystemUser returns null and breaks Dialogporten.
Added two tests — the existing ones missed this, since the derived URN happens to match the API value for the common party types.
Description
Related Issue(s)
Verification
Documentation