Add a --shrink flag, and improve Python 3 compatibility of that code #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to use the gdishrink function from the command line, and additionally significantly improves the Python 3 compatibility of that code. First up, it encodes some stuff which was strings as bytes. Secondly, it fixes one instance where a calculation could sometimes result in a float value, which I believe Python 2 would transparently truncate to an int if needed, but Python 3 requires explicit truncation. I'm not hugely familiar with getopt, so if there's a better way to insert these functions I'm all ears.
Author
|
Updated with another bit of Py3 compatibility; it now handles games with additional GD-DA audio tracks in the high density area without crashing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to use the gdishrink function from the command line, and additionally significantly improves the Python 3 compatibility of that code.
First up, it encodes some stuff which was strings as bytes.
Secondly, it fixes one instance where a calculation could sometimes result in a float value, which I believe Python 2 would transparently truncate to an int if needed, but Python 3 requires explicit truncation.
I'm not hugely familiar with getopt, so if there's a better way to insert these functions I'm all ears.