[동적 계획법] 10월 1일 #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### 인적사항 이름: 조수아 학번: 2371060 ### 과제 제출 기존 제출: 2579, 11053, 20923
flowing1ife
reviewed
Oct 8, 2024
Comment on lines
+6
to
+7
| int stepScores[MAX]; //각 계단의 점수 | ||
| int maxScores[MAX]; //각 계단까지의 최대 점수를 저장하는 배열 |
There was a problem hiding this comment.
P2
벡터 선언시에 n개 또는 n+1개만큼만 선언해준다면 메모리 측면에서 더욱 효율적인 코드가 될 것 같습니다 !
|
|
||
|
|
||
| //최대 점수를 계산하는 함수 | ||
| void calculateMaxScore() { |
ruruisryu
reviewed
Oct 9, 2024
Comment on lines
+9
to
+11
| int getMax(int a, int b) { //두 수 중 더 큰 값을 반환하는 함수 | ||
| return (a > b) ? a : b; | ||
| } |
There was a problem hiding this comment.
최대값을 반환하는 함수는 C++에 구현되어 있는 함수를 써주시면 좋을 것 같아요!
Comment on lines
+7
to
+8
| deque<int> doGround; //도도의 카드 | ||
| deque<int> suGround; //수연의 카드 |
| } | ||
|
|
||
| string winner = ""; //승자 | ||
| playGame(dodo, suyeon, m, winner); |
Comment on lines
+34
to
+53
| if (!doGround.empty() && !suGround.empty() && doGround.back() + suGround.back() == 5) { | ||
| while (!doGround.empty()) { | ||
| suyeon.push_front(doGround.front()); | ||
| doGround.pop_front(); | ||
| } | ||
| while (!suGround.empty()) { | ||
| suyeon.push_front(suGround.front()); | ||
| suGround.pop_front(); | ||
| } | ||
| } | ||
| else if ((!doGround.empty() && doGround.back() == 5) || (!suGround.empty() && suGround.back() == 5)) { | ||
| while (!suGround.empty()) { | ||
| dodo.push_front(suGround.front()); | ||
| suGround.pop_front(); | ||
| } | ||
| while (!doGround.empty()) { | ||
| dodo.push_front(doGround.front()); | ||
| doGround.pop_front(); | ||
| } | ||
| } |
There was a problem hiding this comment.
비슷한 행위를 하는 코드가 반복적으로 쓰여져 있는 것을 확인할 수 있네요. 함수로 따로 뺴주시면 좋을 것 같아요!
Comment on lines
+16
to
+22
| if (isDodoTurn) { | ||
| doGround.push_back(dodo.back()); | ||
| dodo.pop_back(); | ||
| } else { | ||
| suGround.push_back(suyeon.back()); | ||
| suyeon.pop_back(); | ||
| } |
There was a problem hiding this comment.
비슷한 행위를 하는 코드가 반복적으로 쓰여져 있는 것을 확인할 수 있네요. 함수로 따로 뺴주시면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
인적사항
이름: 조수아
학번: 2371060
과제 제출
기존 제출: 2579, 11053, 20923