chore(root): move stray files into scripts/ and docs/ - #27
Merged
Conversation
MakerNSIS.ts was build tooling sitting at the repo root; it joins its sibling generate-installer-art.mjs in scripts/. The two provenance text files join the other prose in docs/. Packaging still ships both notices under their original names, so installed clients see no difference. Updated references: forge.config.ts (import, notice copy paths), tsconfig.json include, verify-package.mjs notice sources, branding.ts notices URL, installer-nsis test imports, README links, and the two docs that pointed at ../PATCHED_ELECTRON.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root entry count drops from 21 to 18. Three files were not root material:
MakerNSIS.ts→scripts/MakerNSIS.ts: build tooling, now beside its siblinggenerate-installer-art.mjs. The NSIS script it generates is byte-identical (99% rename similarity, one import path changed).PATCHED_ELECTRON.txt→docs/PATCHED_ELECTRON.txt: provenance prose, now with the other docs. The README documentation index links it.THIRD_PARTY_NOTICES.txt→docs/THIRD_PARTY_NOTICES.txt: same treatment.Packaged clients see no difference:
forge.config.tsstill copies both notices into the packaged resources under their original names, andverify-package.mjschecks the packaged copies against the new source paths. The in-client "Open-source notices" button URL now points atdocs/THIRD_PARTY_NOTICES.txtonmain.Reference updates:
forge.config.tsimport and notice copy paths,tsconfig.jsoninclude (MakerNSIS.ts→scripts/**/*),scripts/verify-package.mjsnotice sources,src/branding.tsnotices URL,tests/installer-nsis.test.tsimports, README links, and the../PATCHED_ELECTRON.txtlinks in two docs.Verification
pnpm run validatepasses: lint, typecheck, 586/586 tests (the first run caught a stale relative import in the moved maker, fixed).bundle/output.The remaining 18 root entries are tool manifests (
package.json, lockfile, workspace file,tsconfig.json,biome.jsonc,forge.config.ts), the standard doc trio, and the seven directories.Next: your review. Nothing for you to do until then.