fix(performance): eliminate menu error spam and repeated full scans - #30
Open
Alx8g wants to merge 8 commits into
Open
fix(performance): eliminate menu error spam and repeated full scans#30Alx8g wants to merge 8 commits into
Alx8g wants to merge 8 commits into
Conversation
A hidden renderer receives no compositor frames, so with Launch Animation off Krunker's load could stall before ready-to-show and the launch deadlocked behind a black screen. The intro path always shows the window at its opaque reveal; the no-intro path now does the same as soon as the navigation starts. Also fixes two renderer crashes hit on every launch: - whenDOMReady reached observer and poll before their declarations whenever the body already existed, killing the reload/fallback applyClientVisuals pass (theme, identity and keyframe fix never ran). - menu declutter called every/filter on NodeLists returned by querySelectorAll, throwing a repeating Uncaught TypeError on the menu.
Alx8g
changed the base branch from
main
to
fix/reveal-game-window-without-intro
September 4, 2026 22:29
Alx8g
changed the base branch from
fix/reveal-game-window-without-intro
to
main
September 4, 2026 22:37
Alx8g
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I integrated the existing startup/menu crash fix and stopped full menu scans for unrelated text updates. The earlier identity optimisations remain included.
Live CPU-only menu captures before and after showed:
The audit evidence covers six captures and the rendering, startup, memory, input, effects, networking and background-work review.
Maps differed, so these are menu-overhead findings, not a gameplay FPS comparison. Busy-match and sustained-load tests remain unverified because the browser harness could not attach.
No resolution/effect reductions or input/network flag changes. All 597 tests, lint, typechecking and bundle verification passed. The 51 performance checks also passed locally. Windows, macOS, Linux and performance CI passed.
Nothing is merged or installed. This remains a review build.