feat(drawer): mouse move and css units management #1249
Conversation
fbasso
force-pushed
the
mouse-directive
branch
10 times, most recently
from
a4491e0 to
a3c3922
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 90.61% 85.82% -4.80%
==========================================
Files 117 50 -67
Lines 3399 2349 -1050
Branches 545 420 -125
==========================================
- Hits 3080 2016 -1064
- Misses 205 227 +22
+ Partials 114 106 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fbasso
force-pushed
the
mouse-directive
branch
8 times, most recently
from
2e4dcf3 to
e1d38d2
Compare
fbasso
changed the title
fbasso
force-pushed
the
mouse-directive
branch
10 times, most recently
from
95764c9 to
083426b
Compare
fbasso
force-pushed
the
mouse-directive
branch
3 times, most recently
from
0eca38d to
5abf3ac
Compare
| encapsulation: ViewEncapsulation.None, | ||
| }) | ||
| export default class SizesDrawerComponent { | ||
| width = '20rem'; |
There was a problem hiding this comment.
not needed anymore
| --#{$prefix}drawer-size: max-content; | ||
| --#{$prefix}drawer-min-size: 0; | ||
| --#{$prefix}drawer-max-size: none; | ||
| --#{$prefix}drawer-splitter-size: 8px; |
There was a problem hiding this comment.
it seems to be replaced by $splitter-size
There was a problem hiding this comment.
True. Finally, I changed it for the css version, as this is something that we may want to customize.
core/src/components/drawer/drawer.ts
Outdated
| }, | ||
| })); | ||
| onMoveEnd() { | ||
| const newSize = drawerElement$()![isVertical$() ? 'offsetHeight' : 'offsetWidth']; |
There was a problem hiding this comment.
maybe we can already add a bit of logic when the currentSize gets to the minimum width (or some specified value) - we close the drawer? Because currently we can drag it all the way to the left and it leaves only a tiny bit of splitter out
| maxSize = element.getBoundingClientRect()[dimension] + 'px'; | ||
| context.maxSize = maxSize; | ||
| } | ||
| // if (!maxSize) { |
There was a problem hiding this comment.
still need the commented code?
core/src/utils/writables.ts
Outdated
| }; | ||
|
|
||
| /** | ||
| * A writable with default options that normalizes its value to a boolean or null. |
There was a problem hiding this comment.
typo in the comments:, has to be: number or null
fbasso
force-pushed
the
mouse-directive
branch
3 times, most recently
from
4ca25da to
28ac809
Compare
|
|
||
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| imports: [SlotDirective, DrawerStructureDirective, UseDirective], |
There was a problem hiding this comment.
UseDirective is not needed anymore here
fbasso
force-pushed
the
mouse-directive
branch
3 times, most recently
from
45729e3 to
d6efee5
Compare
core/src/components/drawer/drawer.ts
Outdated
| onMoveStart() { | ||
| const isVertical = isVertical$(); | ||
| viewportSize = window[isVertical ? 'innerHeight' : 'innerWidth']; | ||
| const drawerElement = drawerElement$(); |
There was a problem hiding this comment.
probably we can avoid having the if and directly go with drawerElement$()! as in moveEnd as it is always there (+saves coverage :D)
fbasso
force-pushed
the
mouse-directive
branch
from
d6efee5 to
0a48438
Compare
2 participants
No description provided.