Skip to content

fix(ci): correct image tagging and PyPI publishing logic #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wherka-ama merged 1 commit into from
Mar 23, 2025
+10 −5
Merged

fix(ci): correct image tagging and PyPI publishing logic #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release-oci-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
outputs:
generated_version: ${{ steps.output-generated-version.outputs.generated_version }}
image_tag: ${{ steps.generate_tag.outputs.image_tag }}
image_tag_latest: ${{ steps.output-generated-version.outputs.image_tag_latest }}
image_tag_latest: ${{ steps.generate_tag.outputs.image_tag_latest }}
tag_prefix: ${{ steps.generate_tag.outputs.tag_prefix }}
permissions:
contents: write
Expand All @@ -57,7 +57,6 @@ jobs:
id: output-generated-version
run: |
echo "generated_version=${{ steps.semantic-version.outputs.version }}" >> $GITHUB_OUTPUT
echo "image_tag_latest=${{ env.OCI_REGISTRY }}/${repo_name}:latest" >> $GITHUB_OUTPUT

-
name: Version tag ${{ steps.semantic-version.outputs.version }} on main branch or tag
Expand Down Expand Up @@ -85,6 +84,7 @@ jobs:
# image tag needs to be all lower case
repo_name=$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]')
echo "image_tag=${{ env.OCI_REGISTRY }}/${repo_name}:${{ env.generated_tag }}" >> $GITHUB_OUTPUT
echo "image_tag_latest=${{ env.OCI_REGISTRY }}/${repo_name}:latest" >> $GITHUB_OUTPUT

docker-image-release:
needs: [generate-release-version]
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/release-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
- v*
branches:
- main
# paths-ignore:
# - .github/**
# - ./**/*.md
pull_request:
branches:
- main
Expand Down Expand Up @@ -119,8 +122,8 @@ jobs:

publish-to-testpypi:
name: Publish Python 🐍 distribution 📦 to TestPyPI
# we only publish to TestPyPI on tag pushes or merge to main
if: startsWith(github.ref, 'refs/tags/') || github.ref == 'refs/heads/main'
# we only publish to TestPyPI on merge to main
if: github.ref == 'refs/heads/main' && github.event_name == 'push'
needs:
- build
runs-on: ubuntu-latest
Expand All @@ -141,4 +144,6 @@ jobs:
- name: Publish distribution 📦 to TestPyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/
repository-url: https://test.pypi.org/legacy/
skip-existing: true
verbose: true