chore(ama-sdk-schematics): ignore coverage for generated files #3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit cb23d86.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
from
3b05b5a to
a502d1c
Compare
...pescript/core/openapi-codegen-typescript/src/main/resources/typescriptFetch/api/api.mustache
Outdated
Show resolved
Hide resolved
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
5 times, most recently
from
d8453d0 to
d18a465
Compare
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
from
d18a465 to
41fe54e
Compare
matthieu-crouzet
had a problem deploying
to
development
GitHub Actions
Failure
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
from
1d2910e to
18e4515
Compare
mrednic-1A
reviewed
Apr 10, 2025
mrednic-1A
reviewed
Apr 10, 2025
packages/@ama-sdk/schematics/schematics/ng-update/typescript/v12.3/coverage-ignore.spec.ts
Show resolved
Hide resolved
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
4 times, most recently
from
23d3705 to
df2644f
Compare
packages/@ama-sdk/schematics/testing/mocks/jest-config/result.jest.config.js
Show resolved
Hide resolved
matthieu-crouzet
previously approved these changes
Apr 15, 2025
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
2 times, most recently
from
a328818 to
1ad0c9b
Compare
matthieu-crouzet
previously approved these changes
Apr 17, 2025
cpaulve-1A
reviewed
Apr 18, 2025
| && ts.isBinaryExpression(statement.expression) | ||
| && /module\.exports/.test(statement.expression.left.getText(rootNode)) | ||
| && ts.isObjectLiteralExpression(statement.expression.right) | ||
| && !statement.expression.right.properties.some((prop) => ts.isPropertyAssignment(prop) && prop.name.getText(rootNode) === 'coveragePathIgnorePatterns') |
There was a problem hiding this comment.
Should we try to complete missing files if the coveragePathIgnorePatterns is already defined?
There was a problem hiding this comment.
I would say that discovering intersection between globs is a bit too much :D.
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
from
1ad0c9b to
11a6c6c
Compare
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
from
11a6c6c to
ff75992
Compare
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
from
ff75992 to
edd3188
Compare
kpanot
force-pushed
the
chore/coverage-ignore-sdk
branch
from
edd3188 to
cb23d86
Compare
fpaul-1A
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
chore(ama-sdk-schematics): ignore coverage for generated files
Related issues
- No issue associated -