Skip to content

feat: parameter deserialization #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

feat: parameter deserialization #3116

merged 1 commit into from
May 15, 2025

Conversation

sdo-1A
Copy link
Contributor

@sdo-1A sdo-1A commented Apr 10, 2025

Proposed change

Provide deserialization functions as a tool to deserialize query and path parameters.
This PR was created as a split of PR #3076

Related issues

- No issue associated -

@sdo-1A sdo-1A requested a review from a team as a code owner April 10, 2025 13:00
Copy link

nx-cloud bot commented Apr 10, 2025

View your CI Pipeline Execution ↗ for commit 82f68c0.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 12m 22s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 2m 36s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 32s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 7s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 6m 54s View ↗
nx affected --target=test --collectCoverage --c... ✅ Succeeded 40s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded 4s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-05-14 15:22:49 UTC

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.85%. Comparing base (2fa4a61) to head (82f68c0).
Report is 166 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ges/@ama-sdk/core/src/fwk/param-deserialization.ts 97.14% 1 Missing and 1 partial ⚠️
...kages/@ama-sdk/core/src/fwk/param-serialization.ts 80.00% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sdo-1A sdo-1A force-pushed the feat/param-deserialization branch from 8a7ca39 to 50908c7 Compare April 10, 2025 16:12
fpaul-1A
fpaul-1A previously approved these changes Apr 10, 2025
mrednic-1A
mrednic-1A previously approved these changes Apr 11, 2025
@sdo-1A sdo-1A force-pushed the feat/param-deserialization branch 2 times, most recently from 08e3086 to c442888 Compare May 14, 2025 14:52
@sdo-1A sdo-1A force-pushed the feat/param-deserialization branch from c442888 to 82f68c0 Compare May 14, 2025 14:53
@sdo-1A sdo-1A added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit a5b9bbf May 15, 2025
32 checks passed
@sdo-1A sdo-1A deleted the feat/param-deserialization branch May 15, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants