feat: add o3r prefix to generators #3152
Conversation
|
View your CI Pipeline Execution ↗ for commit 93ed0ec.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -7,30 +7,45 @@ | |||
| "schema": "./schematics/ng-add/schema.json", | |||
| "aliases": ["install", "i"] | |||
| }, | |||
| "migrate": { | |||
| "ama-migrate": { | |||
There was a problem hiding this comment.
It's not really the way we discuss it with the team
We said that we should have something [o3r] xxx for the description
not to change the generator name
because in this case you will have some with the prefix and some without if we want to override the one from Angular or from another library
There was a problem hiding this comment.
They are still replacing the Angular's ones thanks to the alias but indeed both Otter and original ones will appear in the --help, one of the advances is that they are grouped in the display and all accessible generated will appear.
I can of course update the PR and change to comments if it is the preferred choice from the team.
As general comment: if a decision refining a issue is taken in an internal discussion, the issue should be updated with the output.
Proposed change
feat: add o3r prefix to generators
Related issues