fix: right click contextual menu for sources#13
Closed
gblanc-1a wants to merge 1 commit intoAmadeusITGroup:mainfrom
Closed
fix: right click contextual menu for sources#13gblanc-1a wants to merge 1 commit intoAmadeusITGroup:mainfrom
gblanc-1a wants to merge 1 commit intoAmadeusITGroup:mainfrom
Conversation
- Extract sourceId from RegistryTreeItem when invoked from contextual menu - Add commandUtils.ts with extractSourceId() helper function - Update editSource, removeSource, syncSource, and toggleSource to handle tree items - Add comprehensive property-based tests for parameter extraction logic Fixes issue where contextual menu commands failed because they received RegistryTreeItem objects instead of string IDs. Commands now properly extract the source ID from tree items while maintaining backward compatibility with command palette and direct invocations.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Closes #
Fixes #
Relates to #
Changes Made
Testing
Test Coverage
Manual Testing Steps
Tested On
macOS
Windows
Linux
VS Code Stable
VS Code Insiders
Screenshots
Checklist
Documentation
Additional Notes
Reviewer Guidelines
Please pay special attention to:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache License 2.0.