Use postcard instead of bincode in tests#507
Merged
Merged
Conversation
Owner
|
Sure, I don't mind. In the end all we need is some implementation of serde to check that our trait implementations are correct. It doesn't really matter which back-end we use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone in contact with the bincode maintainers has mentioned that it's not really maintained anymore and recommended the ecosystem switch away from it:
This PR isn't really "it's important that parking_lot needs to stop using bincode in its tests and switch to something else". It's moreso that parking_lot is a very popular reverse dependency of bincode, and the hope is that by switching away from it, the broader ecosystem is encouraged to look for alternatives and stop reaching for bincode just because it's already popular.