refactor: depends on gtk-mac-integration#35
refactor: depends on gtk-mac-integration#35eatyourbaby wants to merge 1 commit intoAmar1729:mainfrom
Conversation
|
Neato, i think this looks good to me. Do you know if this patch is planned to be upstreamed? |
|
I wrote this patch a long time ago and thought about upstreaming it. As it turns out, there was a more comprehensive patch (deluge-torrent/deluge#273) but the Deluge team haven't been responsive to PRs for a long time. It seems there's only one active dev left, so I didn't bother. I've switched from Deluge to qBittorrent a while back, because Deluge still doesn't support dual stack IPv4 + IPv6 (There's a 5-year-old PR at this point: deluge-torrent/deluge#300). I found this patch digging through my files and decided to upstream here instead. |
4f0daf4 to
e864d24
Compare
|
Makes sense. Yeah, tbh i've also been considering switching given the slower dev happening. Thanks for cleaning up and submitting the PR, appreciate it. Rebased + bumped revision to make brew test-bot a bit happier, and should be merging soon. |
Depends on
gtk-mac-integrationto use macOS native menu bar.It require a patch due to breaking changes in GTK, and to use file dialogues. It's embedded inline in the formula because it's easier for PR.