Skip to content

refactor: depends on gtk-mac-integration#35

Closed
eatyourbaby wants to merge 1 commit intoAmar1729:mainfrom
eatyourbaby:gtk-mac-integration
Closed

refactor: depends on gtk-mac-integration#35
eatyourbaby wants to merge 1 commit intoAmar1729:mainfrom
eatyourbaby:gtk-mac-integration

Conversation

@eatyourbaby
Copy link
Contributor

@eatyourbaby eatyourbaby commented Dec 30, 2025

Depends on gtk-mac-integration to use macOS native menu bar.

It require a patch due to breaking changes in GTK, and to use file dialogues. It's embedded inline in the formula because it's easier for PR.

@Amar1729
Copy link
Owner

Amar1729 commented Jan 2, 2026

Neato, i think this looks good to me. Do you know if this patch is planned to be upstreamed?

@eatyourbaby
Copy link
Contributor Author

I wrote this patch a long time ago and thought about upstreaming it. As it turns out, there was a more comprehensive patch (deluge-torrent/deluge#273) but the Deluge team haven't been responsive to PRs for a long time. It seems there's only one active dev left, so I didn't bother.

I've switched from Deluge to qBittorrent a while back, because Deluge still doesn't support dual stack IPv4 + IPv6 (There's a 5-year-old PR at this point: deluge-torrent/deluge#300). I found this patch digging through my files and decided to upstream here instead.

@Amar1729 Amar1729 force-pushed the gtk-mac-integration branch from 4f0daf4 to e864d24 Compare January 5, 2026 06:23
@github-actions github-actions bot closed this in 54d581d Jan 5, 2026
@Amar1729
Copy link
Owner

Amar1729 commented Jan 5, 2026

Makes sense. Yeah, tbh i've also been considering switching given the slower dev happening. Thanks for cleaning up and submitting the PR, appreciate it.

Rebased + bumped revision to make brew test-bot a bit happier, and should be merging soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants