fix:airdrop.sol check conditions #890
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Airdrop contract's token allowance validation logic that would incorrectly reject airdrops when the approved token amount exactly equals the required airdrop amount.
- Changed the allowance check from strict greater-than (
>) to greater-than-or-equal (>=) - Updated the Chinese comment to reflect the corrected validation logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
XdpCs
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this (这是什么类型的PR)
Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))
如果授权100，空投数量为100，那么会失败。
What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)
修复了代币授权数量的检查