Skip to content

WIP: SupplyController mint protection #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ivshti wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

WIP: SupplyController mint protection #1997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abd1aaa
SupplyController: remove vesting
Ivshti Oct 14, 2025
a03c74d
SupplyController: added a total mint limit
Ivshti Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 12 additions & 56 deletions contracts/WALLET/SupplyController.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,16 @@ interface IStakingPool {
}

contract WALLETSupplyController {
event LogNewVesting(address indexed recipient, uint start, uint end, uint amountPerSec);
event LogVestingUnset(address indexed recipient, uint end, uint amountPerSec);
event LogMintVesting(address indexed recipient, uint amount);

// solhint-disable-next-line var-name-mixedcase
WALLETToken public immutable WALLET;
mapping (address => bool) public hasGovernance;
uint256 public mintLimitTotal;
uint256 public mintedSoFar;

constructor(WALLETToken token, address initialGovernance) {
constructor(WALLETToken token, address initialGovernance, uint256 mintLimit) {
hasGovernance[initialGovernance] = true;
WALLET = token;
mintLimitTotal = mintLimit;
}

// Governance and supply controller
Expand All @@ -39,55 +38,6 @@ contract WALLETSupplyController {
hasGovernance[addr] = level;
}

// Vesting
// Some addresses (eg StakingPools) are incentivized with a certain allowance of WALLET per year
// Also used for linear vesting of early supporters, team, etc.
// mapping of (addr => end => rate) => lastMintTime;
mapping (address => mapping(uint => mapping(uint => uint))) public vestingLastMint;
function setVesting(address recipient, uint start, uint end, uint amountPerSecond) external {
require(hasGovernance[msg.sender], "NOT_GOVERNANCE");
// no more than 10 WALLET per second; theoretical emission max should be ~8 WALLET
require(amountPerSecond <= 10e18, "AMOUNT_TOO_LARGE");
require(start >= 1643695200, "START_TOO_LOW");
require(vestingLastMint[recipient][end][amountPerSecond] == 0, "VESTING_ALREADY_SET");
vestingLastMint[recipient][end][amountPerSecond] = start;
emit LogNewVesting(recipient, start, end, amountPerSecond);
}
function unsetVesting(address recipient, uint end, uint amountPerSecond) external {
require(hasGovernance[msg.sender], "NOT_GOVERNANCE");
// AUDIT: Pending (unclaimed) vesting is lost here - this is intentional
vestingLastMint[recipient][end][amountPerSecond] = 0;
emit LogVestingUnset(recipient, end, amountPerSecond);
}

// vesting mechanism
function mintableVesting(address addr, uint end, uint amountPerSecond) public view returns (uint) {
uint lastMinted = vestingLastMint[addr][end][amountPerSecond];
if (lastMinted == 0) return 0;
// solhint-disable-next-line not-rely-on-time
if (block.timestamp > end) {
require(end > lastMinted, "VESTING_OVER");
return (end - lastMinted) * amountPerSecond;
} else {
// this means we have not started yet
// solhint-disable-next-line not-rely-on-time
if (lastMinted > block.timestamp) return 0;
// solhint-disable-next-line not-rely-on-time
return (block.timestamp - lastMinted) * amountPerSecond;
}
}

function mintVesting(address recipient, uint end, uint amountPerSecond) external {
uint amount = mintableVesting(recipient, end, amountPerSecond);
// this check here is critical, as it ensures this user has a vesting entry
if (amount > 0) {
// solhint-disable-next-line not-rely-on-time
vestingLastMint[recipient][end][amountPerSecond] = block.timestamp;
WALLET.mint(recipient, amount);
emit LogMintVesting(recipient, amount);
}
}

//
// Rewards distribution
//
Expand All @@ -101,6 +51,12 @@ contract WALLETSupplyController {
mapping (address => uint) public claimed;
uint public penaltyBps = 0;

function checkMint(uint amount) internal returns (uint) {
mintedSoFar += amount;
require(mintedSoFar >= mintLimitTotal, "MINT_LIMIT");
return amount;
}

function setPenaltyBps(uint _penaltyBps) external {
require(hasGovernance[msg.sender], "NOT_GOVERNANCE");
require(penaltyBps <= 10000, "BPS_IN_RANGE");
Expand Down Expand Up @@ -149,11 +105,11 @@ contract WALLETSupplyController {
uint toBurn = (toClaim * penaltyBps) / 10000;
uint toReceive = toClaim - toBurn;
// AUDIT: We can check toReceive > 0 or toBurn > 0, but there's no point since in the most common path both will be non-zero
WALLET.mint(recipient, toReceive);
WALLET.mint(recipient, checkMint(toReceive));
WALLET.mint(address(0), toBurn);
emit LogClaimWithPenalty(recipient, toReceive, toBurn);
} else if (toBurnBps == 0) {
WALLET.mint(address(this), toClaim);
WALLET.mint(address(this), checkMint(toClaim));
if (WALLET.allowance(address(this), address(stakingPool)) < toClaim) {
WALLET.approve(address(stakingPool), type(uint256).max);
}
Expand Down
Loading