Add Colibri verified RPC provider (env-gated) #2124
Open
simon-jentzsch wants to merge 2 commits intoAmbireTech:v2from
Open
Add Colibri verified RPC provider (env-gated) #2124simon-jentzsch wants to merge 2 commits intoAmbireTech:v2from
simon-jentzsch wants to merge 2 commits intoAmbireTech:v2from
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
|
Thanks for your PR. We will discuss further internally the option for having this and will get back to you. Just so you know, we currently are having ongoing efforts to refactor the RPC provider usage across the whole app to always use the Provider controller instance from the background. Ideally, completing this would be a prerequisite before having your changes. Otherwise - different parts of the code (including the extension front-end) still create or use their own provider references when making RPC requests and I'm not sure the changes you did would fit in consistently. Let's touch-base again in the next days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.