Skip to content

Fix / Filter out dApps with invalid urls #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonytooo wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

Fix / Filter out dApps with invalid urls #2204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f39b44c
filter out the dapps with invalid url
sonytooo Feb 25, 2026
e5cbf81
fixes
sonytooo Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/controllers/dapps/dapps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ export class DappsController extends EventEmitter implements IDappsController {
const prevDapps = new Map(this.#dapps)

for (const dapp of fetchedDappsList) {
if (!dapp.url || !isValidURL(dapp.url)) continue
if (categoriesToExclude.includes(dapp.category)) continue
if (defiLlamaProtocolIdsToExclude.includes(dapp.id)) continue

Expand Down Expand Up @@ -357,6 +358,7 @@ export class DappsController extends EventEmitter implements IDappsController {

// Add predefined
for (const pd of predefinedDapps) {
if (!pd.url || !isValidURL(pd.url)) continue
const id = getDappIdFromUrl(pd.url)

const prevStoredDapp = prevDapps.get(id)
Expand Down
Loading