Skip to content

Feature/raw data on sign screen#2353

Open
Oxbobby wants to merge 7 commits intov2from
feature/raw-data-on-sign-screen
Open

Feature/raw data on sign screen#2353
Oxbobby wants to merge 7 commits intov2from
feature/raw-data-on-sign-screen

Conversation

@Oxbobby
Copy link
Copy Markdown
Member

@Oxbobby Oxbobby commented May 4, 2026

Add a signingRequest.ts library to present the final data sent to the hardware device in a json friendly way

@Oxbobby Oxbobby self-assigned this May 4, 2026
@Oxbobby Oxbobby added the enhancement New feature or request label May 4, 2026
@Oxbobby
Copy link
Copy Markdown
Member Author

Oxbobby commented May 7, 2026

/review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
⚡ Recommended focus areas for review

Swallowed Error

The #setHardwareWalletSigningRequest method silently catches and discards any errors thrown by getSigningRequestDisplayData. If serialization fails due to malformed data or a bug in the signing request library, the hardware wallet signing request is set to null without any logging, making debugging impossible and potentially leaving the sign screen blank for users.

try {
  if (request) serializedRequestData = getSigningRequestDisplayData(request)
} catch {
  serializedRequestData = null
}

@Oxbobby Oxbobby requested a review from Maskln May 7, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Review effort 3/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants