Feature / support Chrome side panel overlay view and in-panel request handling#2518
Open
Maskln wants to merge 7 commits into
Open
Feature / support Chrome side panel overlay view and in-panel request handling#2518Maskln wants to merge 7 commits into
Maskln wants to merge 7 commits into
Conversation
Member
Author
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Member
Author
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paired with: https://github.com/AmbireTech/ambire-app/pull/7448
Summary
Adds controller-layer support for running the extension in Chrome’s side panel instead of a separate popup request window.
side-panelas an extension overlay view type alongsidepopup, and updateUiControllerto treat popup/side-panel as a single overlay slot (swap type in place when the user toggles modes).RequestsControllerto detect an open side panel and skip opening/focusing a request window; action requests are rendered in-place in the panel viacurrentUserRequest.dismissActiveRequest()with the same queue semantics as closing the request window (calls stay queued, non-calls are rejected per existing rules).#onActiveRequestDismissed()/#handleRequestWindowClose()logic so popup close and side-panel dismiss behave consistently.dapps,transfer, andmaincontrollers where overlay view type matters.Test plan
currentUserRequest.