Domains test/ change import#2521
Open
JIOjosBG wants to merge 2 commits into
Open
Conversation
jordan-enev
approved these changes
Jul 6, 2026
superKalo
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/AmbireTech/ambire-app/pull/7454
Tests used to run with tslib v1 but since we are removing node_modules from ambire-common, the default tslib in ambire-app that ends up being used is v2.
The exported values that are imported from the barrel file (index) are exported via getters in the compiled code (with tslib v2), which prevents jest from doing spyOn.
The fix is to import those values from the original file rather than the index file
This fix is preferred over fixing the ambire-app tslib version to 1 instead of 2