Refactor/ Domains controller and implement gwei names#2532
Conversation
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
gergana95
left a comment
There was a problem hiding this comment.
Tested and works great, did not find any issues. Great work 🙌
| } | ||
|
|
||
| matches(domain: string): boolean { | ||
| return domain.endsWith('.gwei') |
There was a problem hiding this comment.
This resolves donnoh.gwei but not DONNOH.GWEI. This may be correct, just checkin
Reworks domain resolution so the wallet can resolve names from more than just ENS. Instead of ENS/Namoshi being hardcoded, each name service is now a small self-contained resolver, and adding a new ENS-compatible service is a few lines. Also adds GNS (.gwei) on top of this.
Changes: