Add childrenPath to ParsedQrAccount for BC-UR keypath metadata#2546
Open
Maskln wants to merge 1 commit into
Open
Add childrenPath to ParsedQrAccount for BC-UR keypath metadata#2546Maskln wants to merge 1 commit into
Maskln wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paired with: https://github.com/AmbireTech/ambire-app/pull/7509
Summary
Adds an optional
childrenPathfield toParsedQrAccountso QR wallet import can carry BC-URcrypto-hdkeychildren keypath metadata from the scanned payload.When importing from Keycard Shell via QR, the UR payload encodes derivation in two parts:
m/44'/60'/0')*/*for BIP44 standard,*for Ledger Legacy)Standard Ethereum and Ledger Legacy share the same origin path (
m/44'/60'/0') but use different children patterns. Without exposingchildrenPath, consumers cannot tell them apart and may derive the wrong address.This is a type-only change in ambire-common. The parsing and derivation logic lives in ambire-app (companion PR on branch
qr-code-based-wallets-derivation-paths).Changes
childrenPath?: stringtoParsedQrAccountinsrc/interfaces/keystore.tsTest plan
npm run type:check)m/44'/60'/0'/0(notm/44'/60'/0'/0/0)