Create ICN repository for safety-critical graphics with S1000D-compliant structure#35
Conversation
Co-authored-by: AmedeoPelliccia <164860269+AmedeoPelliccia@users.noreply.github.com>
Co-authored-by: AmedeoPelliccia <164860269+AmedeoPelliccia@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request establishes an S1000D-compliant ICN (Information Control Number) repository for safety-critical graphics in the AMPEL360 Q100 project, replacing Unicode placeholder symbols with a structured asset management system. The PR creates a comprehensive framework for version-controlled graphic asset management covering 16 safety symbols (9 AI/ML indicators + 7 H₂ hazard symbols) with proper traceability, naming conventions, and workflow documentation.
Changes:
- Created ICN repository structure with specification documents, master registry, and 16 placeholder SVG symbols
- Established S1000D-compliant naming convention and directory organization (AI-ML, H2-HAZARD, SAFETY-GENERAL categories)
- Updated existing documentation to reference ICN links instead of emoji placeholders
- Added workflow documentation for source-to-publication graphic asset management with CCB approval gates
- Configured Git LFS preparation in .gitattributes for future binary asset management
Reviewed changes
Copilot reviewed 10 out of 28 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
.gitattributes |
Configures LFS attributes for PNG/AI/PSD/EPS files (has minor syntax issue) |
PUB/CSDB/ICN/ICN_SPECIFICATION.md |
Defines ICN naming convention and management procedures (has documentation clarity issues) |
PUB/CSDB/ICN/_index.csv |
Master registry tracking all 16 symbols with metadata (descriptions don't fully match implementations) |
PUB/CSDB/ICN/AI-ML/*.svg |
9 AI/ML indicator placeholder SVGs (text not converted to paths, metadata inconsistent) |
PUB/CSDB/ICN/H2-HAZARD/*.svg |
7 H₂ hazard placeholder SVGs (text not converted to paths) |
SSOT/LC04_DESIGN_DEFINITION/KNU-00-00-003-ICD-003_icn-repository-specification.md |
ICN repository ICD document (incorrectly claims to resolve already-resolved TBD) |
SSOT/LC04_DESIGN_DEFINITION/KNU-00-00-003-ICD-002_aiml-indication-symbols.md |
Updated to reference ICN links instead of emoji placeholders |
SSOT/LC04_DESIGN_DEFINITION/graphics/h2-symbols/README.md |
H₂ symbol design guidelines (missing hex code for one color) |
SSOT/LC03_SAFETY_RELIABILITY/graphics/source/README.md |
Source file workflow documentation |
SSOT/LC01_PROBLEM_STATEMENT/KNU_PLAN.csv |
Added new KNU entries (has empty field issue) |
SSOT/LC01_PROBLEM_STATEMENT/TBD_REGISTER.csv |
Added new TBD for final graphic design |
KNOT_STATUS_REPORT.md |
Updated progress tracking (has calculation error) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### 2.4 Regex Validation | ||
|
|
||
| ```regex | ||
| ^ICN-AMPEL360-S1-(\d{5})-(\d{4})-(\d{3})-([A-Z])\.(svg|png)$ | ||
| ``` |
There was a problem hiding this comment.
The regex pattern expects a 5-digit field followed by a 4-digit field, but the naming convention table describes these as separate CCC (3-digit) and SS (2-digit) fields. The actual format appears to be CCC+SS concatenated into 5 digits (e.g., "00095" = Chapter 095 + no section padding), followed by SSSS (4-digit subsection). The regex correctly validates the actual format but is inconsistent with the component breakdown in section 2.2. Either update the regex to match separate fields or clarify that CCCSS is a single concatenated 5-digit field.
…/00-00-general/PUB/CSDB/ICN/ICN_SPECIFICATION.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/00-00-general/SSOT/LC04_DESIGN_DEFINITION/graphics/h2-symbols/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/00-00-general/PUB/CSDB/ICN/_index.csv Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/00-00-general/SSOT/LC01_PROBLEM_STATEMENT/KNU_PLAN.csv Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/00-00-general/KNOT_STATUS_REPORT.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/00-00-general/SSOT/LC04_DESIGN_DEFINITION/KNU-00-00-003-ICD-003_icn-repository-specification.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Replaces Unicode placeholder symbols with a proper S1000D-compliant ICN (Information Control Number) repository structure for all safety-critical graphics (9 AI/ML indicators + 7 H₂ hazard symbols). Enables certification-grade traceability, version control, and multi-resolution asset management.
Repository Structure
ICN Naming Convention
Pattern:
ICN-AMPEL360-S1-CCCSS-SSSS-NNN-V.extComponents: ATA Chapter (CCC), Section (SS), Subsection (SSSS), Sequence (NNN), Variant (A-Z)
Placeholder SVG Implementation
All 16 symbols include:
Example structure:
Documentation Updates
Workflow
CCB approval required before moving to approved/. Variant letter increments (A→B→C) for modifications; previous variants retained for traceability.
Registry Schema
_index.csvtracks: ICN, Symbol_ID, Name, Category, ATA Chapter/Section, Source File, Format, SHA256, Version, Status, Approval Date/By, NotesNote: Current SVGs are geometric placeholders. Production symbols require human factors specialist design, pilot usability testing, and certification per DO-178C and EASA CS-25 (tracked as TBD-00-00-003-ICD-003-001).
Original prompt
Create ICN (Information Control Number) Repository for Safety-Critical Graphics
🎯 Objective
Replace Unicode placeholder symbols with a proper S1000D-compliant ICN repository structure for all safety-critical graphics (AI/ML indicators, H₂ hazard symbols). This enables certification-grade traceability, version control, and multi-resolution asset management.
📐 Architecture Overview
📁 Files to Create
1. ICN Specification Document
Path:
PUB/CSDB/ICN/ICN_SPECIFICATION.mdICN-AMPEL360-S1-CCCSS-SSSS-NNN-V.ext
3. Directory Structure
4. File Format Requirements
4.1 SVG (Primary Format)
4.2 PNG (Raster Fallback)
4.3 Color Standards
| Status | Hex Code | RGB | Usage |
|--------|----------|...
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.