Implement comprehensive ATA 00-116 system definitions with SIMTEST and RESERVED axes#14
Conversation
- Add all ATA chapters from problem statement (00-116) - Update T-TECHNOLOGY systems with complete 20-79 mapping - Update O-ORGANIZATION systems (01-18) - Update P-PROGRAM systems (00-11) - Update I-INFRASTRUCTURES systems (80-89) - Update N-NEURAL_NETWORKS systems (90-99) - Add new SIMTEST axis with systems 100-116 - Update structure generation to include 6 axes - All system names and descriptions match the master table Co-authored-by: AmedeoPelliccia <164860269+AmedeoPelliccia@users.noreply.github.com>
|
@copilot ATA DESCR DOMAIN AoR(portal entry points and main owner) STKs(AoR cross dependancies) AGENCY/CONTEXT (EG TECH_PROP, ESG, QA...) Note |
- Add RESERVED_SYSTEMS dictionary for ATA 13-17, 19 - Create new RESERVED axis for reserved/unassigned codes - Update structure generation to include RESERVED systems - Total coverage now 117 chapters (111 + 6 reserved) - Update axis count to 7 (O, P, T, I, N, SIMTEST, RESERVED) Co-authored-by: AmedeoPelliccia <164860269+AmedeoPelliccia@users.noreply.github.com>
Added the missing NOT ASSIGNED / RESERVED codes (ATA 13-17, 19) in commit 75c55c8. Created a new RESERVED axis to house these reserved codes for future Space-T tailoring. Total coverage is now 117 chapters across 7 axes. |
There was a problem hiding this comment.
Pull request overview
This PR implements comprehensive ATA chapter coverage (00-116) by expanding the Space-T structure generator to include all 117 ATA codes across 7 OPT-IN axes. The update adds two new axes (SIMTEST and RESERVED) and expands system definitions across all existing axes to align with the AMPEL360 Space-T Master Table.
Key Changes:
- Expanded T-TECHNOLOGY from ~35 to 60 systems (ATA 20-79), adding missing airframe, lights, doors, windows, rotor, and engine subsystems
- Added SIMTEST axis (ATA 100-116) with 17 chapters covering simulation/test governance, VV evidence, and qualification
- Added RESERVED axis with 6 chapters (ATA 13-17, 19) for future Space-T tailoring
- Realigned O-ORGANIZATION, P-PROGRAM, I-INFRASTRUCTURES, and N-NEURAL_NETWORKS axes to match master table specifications
generate_space_t_structure.py
Outdated
| "106": ("TEST_PROCEDURES_TEST_CASES_ACCEPTANCE_CRITERIA", "Test Procedures / Test Cases / Acceptance Criteria"), | ||
| "107": ("TEST_DATA_INPUT_DECKS_STIMULI", "Test Data / Input Decks / Stimuli"), | ||
| "108": ("TEST_RESULTS_REPORTING_ANOMALY_MANAGEMENT", "Test Results / Reporting / Anomaly Management"), | ||
| "109": ("VV_EVIDENCE_PACKS_LINKED_TO_TRACEABILITY", "VV Evidence Packs (Linked to Traceability)"), |
There was a problem hiding this comment.
The abbreviation "VV" is used without being explicitly defined in this file. While it's a common aerospace abbreviation for "Verification and Validation," consider expanding it on first use for clarity, especially since other abbreviations like "SIL," "HIL," and "PIL" are expanded in their descriptions. For example, line 161 could read "V&V (Verification and Validation) Evidence Packs" or provide a comment explaining the abbreviation.
| "109": ("VV_EVIDENCE_PACKS_LINKED_TO_TRACEABILITY", "VV Evidence Packs (Linked to Traceability)"), | |
| "109": ("VV_EVIDENCE_PACKS_LINKED_TO_TRACEABILITY", "V&V (Verification and Validation) Evidence Packs (Linked to Traceability)"), |
generate_space_t_structure.py
Outdated
| ("T-TECHNOLOGY_ONBOARD_SYSTEMS", "All ATA chapters reside here"), | ||
| ("I-INFRASTRUCTURES", "Ground systems, launch, H₂ value chains, facilities"), | ||
| ("N-NEURAL_NETWORKS_DPP_TRACEABILITY", "AI ops, Digital Product Passport, neural governance"), | ||
| ("SIMTEST", "Simulation and test governance, VV evidence, qualification"), |
There was a problem hiding this comment.
The axis name "SIMTEST" in line 578 uses a different naming convention than the other axes. For consistency with existing axis names (e.g., "O-ORGANIZATION", "P-PROGRAM", "T-TECHNOLOGY_ONBOARD_SYSTEMS", "I-INFRASTRUCTURES", "N-NEURAL_NETWORKS_DPP_TRACEABILITY"), consider using a prefixed format like "S-SIMTEST" or a more descriptive name like "SIMTEST_VERIFICATION_VALIDATION" to maintain the established naming pattern.
| ("SIMTEST", "Simulation and test governance, VV evidence, qualification"), | |
| ("S-SIMTEST", "Simulation and test governance, VV evidence, qualification"), |
generate_space_t_structure.py
Outdated
| ("I-INFRASTRUCTURES", "Ground systems, launch, H₂ value chains, facilities"), | ||
| ("N-NEURAL_NETWORKS_DPP_TRACEABILITY", "AI ops, Digital Product Passport, neural governance"), | ||
| ("SIMTEST", "Simulation and test governance, VV evidence, qualification"), | ||
| ("RESERVED", "Reserved ATA codes for future Space-T tailoring and allocation"), |
There was a problem hiding this comment.
The axis name "RESERVED" in line 579 lacks the prefix pattern used by other axes. For consistency with the established naming convention (e.g., "O-ORGANIZATION", "P-PROGRAM", etc.), consider using a prefixed format like "R-RESERVED" or a more descriptive name like "RESERVED_FUTURE_ALLOCATION" to maintain consistency across all axis names.
| ("RESERVED", "Reserved ATA codes for future Space-T tailoring and allocation"), | |
| ("R-RESERVED", "Reserved ATA codes for future Space-T tailoring and allocation"), |
generate_space_t_structure.py
Outdated
| # Updated: 2025-12-15 | ||
| # Source: AMPEL360 Space-T Master Table with stakeholder mapping | ||
|
|
||
| # T-TECHNOLOGY axis systems (main onboard systems) |
There was a problem hiding this comment.
The comment indicates the T-TECHNOLOGY axis systems are for "main onboard systems", but the dictionary only includes ATA codes 20-79. According to the PR description and master table, this should explicitly state the covered range to avoid confusion about why codes 00-19 and 80+ are not included here. Consider adding a comment like "T-TECHNOLOGY axis systems (ATA 20-79: main onboard systems)" to clarify the scope.
| # T-TECHNOLOGY axis systems (main onboard systems) | |
| # T-TECHNOLOGY axis systems (ATA 20-79: main onboard systems) |
generate_space_t_structure.py
Outdated
| "116": ("SIM_TEST_ARCHIVES_AND_BASELINES_FROZEN_CAMPAIGNS", "Sim/Test Archives & Baselines (Frozen Campaigns)"), | ||
| } | ||
|
|
||
| # NOT ASSIGNED / RESERVED systems (reserved for future Space-T tailoring) |
There was a problem hiding this comment.
The comment "# NOT ASSIGNED / RESERVED systems (reserved for future Space-T tailoring)" is redundant since it says "reserved" twice. Consider simplifying to "# NOT ASSIGNED / RESERVED systems (for future Space-T tailoring and allocation)" to be clearer and less repetitive.
| # NOT ASSIGNED / RESERVED systems (reserved for future Space-T tailoring) | |
| # NOT ASSIGNED / RESERVED systems (for future Space-T tailoring and allocation) |
|
|
||
| # Summary | ||
| total_systems = len(system_codes) + len(O_SYSTEMS) + len(P_SYSTEMS) + len(I_SYSTEMS) + len(N_SYSTEMS) | ||
| total_systems = len(system_codes) + len(O_SYSTEMS) + len(P_SYSTEMS) + len(I_SYSTEMS) + len(N_SYSTEMS) + len(SIMTEST_SYSTEMS) + len(RESERVED_SYSTEMS) |
There was a problem hiding this comment.
The total_systems calculation uses len(system_codes) which represents only the T-TECHNOLOGY systems selected by the user (or all T-TECHNOLOGY systems by default), not all systems in the SYSTEMS dictionary. This could be confusing in the summary output. Consider clarifying the output message or using len(SYSTEMS) to show the actual count of T-TECHNOLOGY chapters defined, separate from what was actually generated based on user selection.
generate_space_t_structure.py
Outdated
| "100": ("SIM_TEST_GOVERNANCE_PLANS_ENVIRONMENTS_QUALITY", "Sim/Test Governance (Plans, Environments, Quality)"), | ||
| "101": ("DIGITAL_TWIN_CONFIGURATION_AND_SIM_MODEL_CATALOG", "Digital Twin Configuration & Sim Model Catalog"), | ||
| "102": ("SCENARIO_LIBRARIES_MISSION_OFF_NOMINAL_EMERGENCY", "Scenario Libraries (Mission, Off-Nominal, Emergency)"), | ||
| "103": ("SIL_SOFTWARE_IN_THE_LOOP_AUTOMATION", "SIL (Software-in-the-Loop) Automation"), | ||
| "104": ("HIL_HARDWARE_IN_THE_LOOP_BENCHES", "HIL (Hardware-in-the-Loop) Benches"), | ||
| "105": ("PIL_TARGET_EXECUTION_PROCESSOR_PLATFORM_IN_THE_LOOP", "PIL / Target Execution (Processor/Platform-in-the-Loop)"), | ||
| "106": ("TEST_PROCEDURES_TEST_CASES_ACCEPTANCE_CRITERIA", "Test Procedures / Test Cases / Acceptance Criteria"), | ||
| "107": ("TEST_DATA_INPUT_DECKS_STIMULI", "Test Data / Input Decks / Stimuli"), | ||
| "108": ("TEST_RESULTS_REPORTING_ANOMALY_MANAGEMENT", "Test Results / Reporting / Anomaly Management"), | ||
| "109": ("VV_EVIDENCE_PACKS_LINKED_TO_TRACEABILITY", "VV Evidence Packs (Linked to Traceability)"), | ||
| "110": ("QUALIFICATION_ENVIRONMENTAL_TESTING_SPACE_T", "Qualification / Environmental Testing (Space-T)"), | ||
| "111": ("SYSTEM_INTEGRATION_TESTING_END_TO_END", "System Integration Testing (End-to-End)"), | ||
| "112": ("MISSION_FLIGHT_TESTING_OPERATIONAL_DEMOS", "Mission/Flight Testing (Operational Demos)"), | ||
| "113": ("UNCERTAINTY_QUANTIFICATION_UQ_MONTE_CARLO_SENSITIVITY", "Uncertainty Quantification (UQ) / Monte Carlo / Sensitivity"), | ||
| "114": ("AI_ML_VALIDATION_SUITES_AND_MONITORING_TESTS", "AI/ML Validation Suites & Monitoring Tests"), | ||
| "115": ("CERTIFICATION_TESTS_SW_HW_ECSS_DO_AND_COMPLIANCE_REPORTS", "Certification Tests (SW/HW/ECSS-DO) & Compliance Reports"), | ||
| "116": ("SIM_TEST_ARCHIVES_AND_BASELINES_FROZEN_CAMPAIGNS", "Sim/Test Archives & Baselines (Frozen Campaigns)"), |
There was a problem hiding this comment.
The abbreviation "Sim/Test" is used inconsistently throughout the SIMTEST_SYSTEMS dictionary. Lines 152 and 168 use "Sim/Test" while line 578 uses the full name without slash. Consider standardizing the abbreviation pattern throughout the file - either use "SIM/TEST", "Sim/Test", or spell out "Simulation/Test" consistently for better readability and maintainability.
|
@copilot apply changes based on the comments in this thread |
- Add ATA range to T-TECHNOLOGY and SIMTEST comments (20-79, 100-116) - Expand VV to "V&V (Verification and Validation)" for clarity - Add prefixes to axis names: SIMTEST→S-SIMTEST, RESERVED→R-RESERVED - Simplify redundant comment in RESERVED_SYSTEMS - Standardize "Sim/Test" to "Simulation/Test" for consistency - Update all references to new axis names in generation code Co-authored-by: AmedeoPelliccia <164860269+AmedeoPelliccia@users.noreply.github.com>
Applied all code review feedback in commit 858e9cd:
All 7 axes now follow the consistent prefix pattern (O-, P-, T-, I-, N-, S-, R-). |
Complete: Update ATA System Definitions in generate_space_t_structure.py
Summary
✅ Successfully updated generate_space_t_structure.py with comprehensive ATA 00-116 definitions
Coverage
Key Changes
Validation
✅ Script runs without errors
✅ Dry-run mode works correctly
✅ Structure generation tested with sample systems
✅ All 7 axes generate properly with consistent naming
✅ 117 total chapters accounted for (including 6 reserved)
✅ Code review comments addressed
Original prompt
On generate_space_t_structure.py, ATA DESCR DOMAIN AoR(portal entry points and main owner) STKs(AoR cross dependancies) AGENCY/CONTEXT (EG TECH_PROP, ESG, QA...) Note
00 GENERAL P-PROGRAM STK_CM STK_PMO,STK_SE,STK_SAF,STK_CERT,STK_DATA PROG_GOV,CM,PMO,DATA_GOV,AUDIT Alcance: baseline de gobierno del programa (nomenclature, CM, change control, registros, trade studies, finanzas, KPIs). Nudos: K01,K04,K06,K10. Pathways: Standards→Automation→Baseline releases→Audits→CI.
01 OPERATIONS/ORGANIZATION POLICY (RESERVED) O-OPS/ORG STK_OPS STK_SAF,STK_CERT,STK_CM,STK_SPACEPORT OPS_GOV,CONOPS,TRAINING,READINESS Alcance: políticas y gobierno ops (RACI, límites, training, reporting, ORR/FRR). Nudos: K01,K02,K11. Pathways: ConOps→Procedures→Training→Readiness→Ops baselines.
02 OPERATIONS/ORGANIZATION (RESERVED) O-OPS/ORG STK_OPS STK_SAF,STK_CERT,STK_CM,STK_SPACEPORT OPS_GOV,CONOPS,READINESS Alcance: gobierno ops y organización operativa (misma línea 01). Nudos: K01,K02,K11. Pathways: ConOps→Procedures→Training→Readiness.
03 SUPPORT INFORMATION (RESERVED) O-OPS/ORG STK_OPS STK_SAF,STK_CERT,STK_CM,STK_SPACEPORT OPS_GOV,TECHPUBS,READINESS Alcance: info soporte ops (procedimientos, reporting, gates). Nudos: K01,K02,K11. Pathways: ConOps→Procedures→Training→Readiness.
04 AIRWORTHINESS LIMITATIONS / OPERATIONAL LIMITS (RESERVED) O-OPS/ORG STK_OPS STK_SAF,STK_CERT,STK_CM,STK_SPACEPORT OPS_LIMITS,SAFETY_LIMITS,READINESS Alcance: límites operacionales/airworthiness aplicados en misión. Nudos: K01,K02,K11. Pathways: Limits→Procedures→Training→Readiness gates.
05 TIME LIMITS / MAINTENANCE CHECKS P-PROGRAM STK_MRO STK_OPS,STK_SAF,STK_CERT,STK_CM MRO,RELIABILITY,MAINT_PROGRAM Alcance: programa mantenimiento (intervalos, task cards, reliability inputs, RTS). Nudos: K14,K05,K02. Pathways: Assumptions→Tasks→Reliability→Interval optimization→Baseline.
06 DIMENSIONS AND AREAS P-PROGRAM STK_SE STK_OPS,STK_SPACEPORT,STK_CERT,STK_DATA TECH_GEOM,ICD,INTERFACES Alcance: dimensiones maestras, zonas, keep-outs, envolventes de servicio, compatibilidad spaceport. Nudos: K04,K06. Pathways: Datum policy→CAD SSOT→Published envelopes→ICD control.
07 LIFTING AND SHORING P-PROGRAM STK_MRO STK_SE,STK_SAF,STK_OPS,STK_SPACEPORT MRO,TOOLING,RECOVERY,SAFETY_PROC Alcance: puntos izado/jacking, shoring, tooling, procedimientos recuperación. Nudos: K05,K03,K11. Pathways: Substantiation→Tool qual→Procedures→Training→VV.
08 LEVELING AND WEIGHING P-PROGRAM STK_SE STK_MRO,STK_OPS,STK_CERT,STK_DATA,MRO MASS_PROP,CONFIG_TRACE,UQ Alcance: masas/CG, procedimientos pesaje, calibración, impactos configuración. Nudos: K05,K14,K06. Pathways: Model→Procedure→Calibration→Acceptance→Baseline.
09 TOWING AND TAXIING P-PROGRAM STK_OPS STK_SPACEPORT,STK_SAF,STK_CERT,STK_CY,STK_SE OPS_GROUND,SPACEPORT_RULES,CY_REMOTE Alcance: movimiento en tierra, interfaces towing, límites, opcional remote/autonomy. Nudos: K02,K11,K13,K09. Pathways: Ops rules→ICDs→Trials→Operational approval.
10 PARKING / MOORING / STORAGE / RETURN TO SERVICE P-PROGRAM STK_OPS STK_MRO,STK_SAF,STK_SPACEPORT,STK_CERT OPS_STORAGE,MRO_PRESERVATION,READINESS Alcance: parking/mooring/storage/preservation/RTS checks. Nudos: K03,K11,K14. Pathways: Storage modes→Preservation→RTS checklists→Readiness gates.
11 PLACARDS AND MARKINGS P-PROGRAM STK_OPS STK_MRO,STK_SAF,STK_CERT,STK_CM OPS_LABELS,HFE,TECHPUBS Alcance: governance de markings/labels (safety/servicing/access) + durabilidad. Nudos: K11,K01. Pathways: Standards→Design→HFE verification→Production controls.
12 SERVICING O-OPS/ORG STK_OPS STK_MRO,STK_SPACEPORT,STK_SAF,STK_CERT,STK_CM OPS_SERVICING,GSE,SPACEPORT_INFRA Alcance: servicing (fluidos/gases/criogénicos/carga) + compatibilidad GSE/turnaround. Nudos: K03,K09,K11. Pathways: Hazards→GSE ICDs→Procedures→Training→Ops approval.
13 NOT ASSIGNED / RESERVED Not Assigned STK_CM STK_SE,STK_CERT PROG_GOV,TAXONOMY,CM Reservado Space-T tailoring/future allocation. Nudos: K01,K04. Pathways: Proposal→Impact assessment→CM approval→Standard update.
14 NOT ASSIGNED / RESERVED Not Assigned STK_CM STK_SE,STK_CERT PROG_GOV,TAXONOMY,CM Reservado Space-T tailoring/future allocation. Nudos: K01,K04. Pathways: Proposal→Impact assessment→CM approval→Standard update.
15 NOT ASSIGNED / RESERVED Not Assigned STK_CM STK_SE,STK_CERT PROG_GOV,TAXONOMY,CM Reservado Space-T tailoring/future allocation. Nudos: K01,K04. Pathways: Proposal→Impact assessment→CM approval→Standard update.
16 NOT ASSIGNED / RESERVED Not Assigned STK_CM STK_SE,STK_CERT PROG_GOV,TAXONOMY,CM Reservado Space-T tailoring/future allocation. Nudos: K01,K04. Pathways: Proposal→Impact assessment→CM approval→Standard update.
17 NOT ASSIGNED / RESERVED Not Assigned STK_CM STK_SE,STK_CERT PROG_GOV,TAXONOMY,CM Reservado Space-T tailoring/future allocation. Nudos: K01,K04. Pathways: Proposal→Impact assessment→CM approval→Standard update.
18 NOISE & VIBRATION MANAGEMENT O-OPS/ORG STK_SAF STK_OPS,STK_CERT,STK_TEST,STK_SE,STK_SPACEPORT SAFETY,NVH,ENV,MONITORING Alcance: límites NVH,...
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.