Fix localStorage bugs with TTL and proper state clearing #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix-draft Fixed draft in chat
…fix-draft fixed arguments for make_chain
…gfix-draft fixed make_chain
Restore internationalization functionality that was lost during recent merges: - Add missing model creation imports to templates.py - Update _yap_generate() to use language-specific models and prompts - Fix _yap_check_finished() to use localized completion keywords - Restore local Whisper fallback when TRANSCRIPTION_API_KEY is missing Fixes TypeError: _yap_generate() takes 3 positional arguments but 4 were given Fixes NameError: name 'GemeenteTurnModel' is not defined Fixes RuntimeError: TRANSCRIPTION_API_KEY not set
This reverts commit d535b3b.
…ffold-postdemo-localstoragefix
…ffold-postdemo-localstoragefix
- Add 30-minute TTL to sessionStore and apiStore to prevent stale data - Fix memory leaks in getSessionId() and getLatestResponse() by using get() - Clear all state when entering flow roots (/1 and /2) on mount - Use Svelte 5 $effect pattern with initialization flag for one-time setup - Auto-expire old sessions and API responses on load
Collaborator
Author
|
ik heb denk ik een fout gemaakt, want hier zitten veel meer commits bij dan de bedoeling was |
Collaborator
Author
|
@kapsterdam Nee is denk ik toch ok: ik heb veranderingen aan het backend gemaakt en teruggedraaid, en jouw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes localStorage-related bugs that caused issues when users restarted flows. Adds TTL expiration and proper state clearing at flow entry points.
Changes
getSessionId()andgetLatestResponse()by using Svelte'sget()helper instead of creating subscriptions/1and/2) on mount using Svelte 5$effectpatternTechnical Details
$effectwith initialization flag for one-time setup on mountTesting
/1or/2