Add recursive search for .git directory [patch] #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AnakinPt: What do you think about this PR? |
AnakinPt
requested changes
Dec 5, 2023
| @@ -50,4 +50,18 @@ public void apply(Project project) { | |||
| tagVersionTask.get().getVersion().set(innerProject.getVersion().toString()); | |||
| }); | |||
| } | |||
|
|
|||
| static File findGitFolder(File rootDir) { | |||
There was a problem hiding this comment.
Don't use static methods.
You can use recursivity better.
findGit(folder){
if folder == null
throw exception
return folder.exists?folder:findFolder(folder.getParentDir)
There was a problem hiding this comment.
Thanks! I replaced the static method and improved the recursivity.
There was a problem hiding this comment.
@AnakinPt could you review again please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of configuring the location of the .git directory as suggested in issue #3, the plugin will recursively search for a .git folder in the directory tree, starting from the project directory. This approach makes the plugin usable for mono-repos as well.