Bug fix for text expander and new text contractor function#1
Open
tura89 wants to merge 2 commits intoAnbani:mainfrom
Open
Bug fix for text expander and new text contractor function#1tura89 wants to merge 2 commits intoAnbani:mainfrom
tura89 wants to merge 2 commits intoAnbani:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the regex pattern in
expand_textfunction to correctly handle abbreviations with multiple commas, such asჩ.წ.ა.The new implementation also accounts for abbreviations not found in the data file.
Previously such abbreviations would cause the function to run indefinitely.
Of note - this doesn't account for abbreviations with spaces in them, such as
ძვ. სტ.. In this specific example, it would get expanded to "ძველი სტამბა" since those are the expansions of those two respective contractions.Probably the only way to fix this would be to loop through each contraction and look them up individually, similar to how the newly implemented
contract_textworks.New functionality example: