Skip to content

[Bug] Dark mode fixes #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Bug] Dark mode fixes #303

wants to merge 2 commits into from

Conversation

@TechWithTyler
Copy link

@TechWithTyler TechWithTyler commented Jan 18, 2023 •
edited
Loading

Background

Fixes UI to properly adapt to dark mode
Closes #304

Breaking Changes

Describe any breaking changes that this pull request will introduce.
iOS 16+ required

Meta

  • Tied to Version Release(s):

PR Checklist

  • CI runs clean? N/A
  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.). Don't have label change access
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

image

@TechWithTyler TechWithTyler changed the title Dark mode fixes [Bug] Dark mode fixes Jan 19, 2023
@TechWithTyler TechWithTyler marked this pull request as ready for review January 19, 2023 00:41
@TechWithTyler TechWithTyler marked this pull request as draft January 20, 2023 00:07
@TechWithTyler TechWithTyler changed the title [Bug] Dark mode fixes Dark mode fixes Jan 20, 2023
@TechWithTyler TechWithTyler changed the title Dark mode fixes [Bug] Dark mode fixes Jan 20, 2023
@TechWithTyler TechWithTyler marked this pull request as ready for review January 20, 2023 00:19
@TechWithTyler TechWithTyler marked this pull request as draft January 20, 2023 00:24
@TechWithTyler TechWithTyler marked this pull request as ready for review January 20, 2023 00:24
@TechWithTyler
Copy link
Author

TechWithTyler commented Jan 20, 2023

@aaronbrethorst @halmueller Let me know if you're able to review this pull request, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dark Mode Doesn't Work Properly

1 participant

@TechWithTyler