Skip to content

fix[glfw]: Fix IndexOOB when requesting GLFW_KEY_LAST #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crystall1nedev merged 1 commit into from
Jun 19, 2025
Merged

fix[glfw]: Fix IndexOOB when requesting GLFW_KEY_LAST #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified app_pojavlauncher/src/main/assets/components/lwjgl3/lwjgl-glfw-classes.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion app_pojavlauncher/src/main/assets/components/lwjgl3/version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4903cfc8d3afd63918f59caf0a146efc2d837069
349d027673855ffded0bb7471a5b662a63b438bd
3 changes: 3 additions & 0 deletions jre_lwjgl3glfw/src/main/java/org/lwjgl/glfw/GLFW.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,9 @@ public static int glfwGetKeyScancode(int key) {
}

public static int glfwGetKey(@NativeType("GLFWwindow *") long window, int key) {
// This is jank, anything asking for int 348 results in an IndexOutOfBounds because idk.
// Probably an off-by-one error. This is the 'fix'
if (key == GLFW_KEY_LAST){return GLFW_KEY_LAST;}
return keyDownBuffer.get(Math.max(0, key-31));
}

Expand Down