Skip to content

qol[Demo]: Prevent local account creation when no Minecraft account is found and make the associated error better#16

Merged
ThatStella7922 merged 5 commits into
AngelAuraMC:v3_openjdkfrom
alexytomi:qol-betterLocalandDemoMessages
Jun 21, 2025
Merged

qol[Demo]: Prevent local account creation when no Minecraft account is found and make the associated error better#16
ThatStella7922 merged 5 commits into
AngelAuraMC:v3_openjdkfrom
alexytomi:qol-betterLocalandDemoMessages

Conversation

@alexytomi

Copy link
Copy Markdown
Member

No description provided.

@alexytomi alexytomi requested a review from ThatStella7922 June 19, 2025 10:53

@ThatStella7922 ThatStella7922 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane at first glance, will test on physical device before approval

@ThatStella7922

ThatStella7922 commented Jun 19, 2025

Copy link
Copy Markdown

Test scenario 1: Open amethyst, click add account, local account.

Result: The error shows up just fine.
Screenshot_2025-06-19-10-55-12-17_59e3738f718bc4374df4f834029b3543

Test scenario 2: Open amethyst, log into a Microsoft account that does not own the game (demo user).
Result: Demo game works normally. Can create a local user after signing into demo MS account.
Screenshot_2025-06-19-11-07-27-92_59e3738f718bc4374df4f834029b3543

Ending feedback:

  • Is being able to create a local user after signing into a demo account intended functionality?
  • Please make the strings localizable

@alexytomi

alexytomi commented Jun 20, 2025

Copy link
Copy Markdown
Member Author

Thanks!

Is being able to create a local user after signing into a demo account intended functionality?

No it is not, logic at 2 am is not a good idea.

Please make the strings localizable

Done! Although the names may be a bit lengthy, I'm bad at naming things

@alexytomi alexytomi requested a review from ThatStella7922 June 20, 2025 16:03
@alexytomi alexytomi force-pushed the qol-betterLocalandDemoMessages branch from 0958840 to 81987d4 Compare June 20, 2025 16:21
@ThatStella7922

ThatStella7922 commented Jun 20, 2025

Copy link
Copy Markdown

The artifact tested: https://github.com/alexytomi/PojavLauncher/actions/runs/15783282077 app-debug-noruntime

App data was cleared between tests for a clean slate

Test scenario 1: Open amethyst, click add account, local account.
Result: Local account can be created without first adding a Microsoft account that owns Java Edition
Screenshot_2025-06-20-17-12-53-03_59e3738f718bc4374df4f834029b3543


Test scenario 2: Open amethyst, log into a Microsoft account that does not own the game (demo user), click add account, local account.
Results: "No Minecraft Account Found, This feature requires a Microsoft account that owns Minecraft Java Edition" error.
Demo game also works normally. Pre-1.3.1 versions are also blocked with correct error.


Ending feedback:
Good localization, but please fix the local account creation

@alexytomi alexytomi force-pushed the qol-betterLocalandDemoMessages branch from 81987d4 to 9e877df Compare June 21, 2025 04:05
@alexytomi

Copy link
Copy Markdown
Member Author

Hope that fixes it 😭

Should also fix demo message being missing in some cases (particularly
in the open directory button when both a demo and ms acc is logged on)
@alexytomi alexytomi force-pushed the qol-betterLocalandDemoMessages branch from 5292e32 to dcdcdff Compare June 21, 2025 04:51

@ThatStella7922 ThatStella7922 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifact tested: https://github.com/alexytomi/PojavLauncher/actions/runs/15792267715

App data cleared between runs

Test scenario 1: Open amethyst, click add account, local account.
Result: Error message is properly shown, nice
image


Test scenario 2: Open amethyst, log into a Microsoft account that does not own the game (demo user), click add account, local account.
Result:
image
image


Ending feedback:
Seems good to me. errors show up fine and the user can't add local accounts until a premium account is added, nor can they play anything pre-1.3.1 until that happens

@ThatStella7922 ThatStella7922 merged commit 66db228 into AngelAuraMC:v3_openjdk Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants