Add neoforge install button + fix forge & neoforge UI becoming disabled when installing a version, requiring a restart to mitigate#17
Merged
crystall1nedev merged 2 commits intoJun 30, 2025
Conversation
alexytomi
force-pushed
the
add-neoforgeInstall
branch
from
ce973f1 to
c77fb89
Compare
Code thought taskProxy was being set to null, when in reality it was actually just the value of it. Rather than just read the value of the key, I just delete the key itself because outside of installing something, we don't need it at all. This bug caused anything implementing ModVersionListFragment to disable the list after one install as the code that handles the edgecase of taskProxy being not null was being triggered but not reset post-install. The faulty code was intended to block the user from being able to run multiple install tasks at once, which wouldn't go well.
I don't know how it manages to make a profile but it does
alexytomi
force-pushed
the
add-neoforgeInstall
branch
from
c77fb89 to
3d7cf8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Majority of the code was stolen from the forge one.
Please check if my taskProxy fix is breaking things, whatever that is exactly supposed to do is unclear to me