Skip to content

fix[MinecraftDownloader]: Better handling in local profile while online#18

Closed
alexytomi wants to merge 0 commit into
AngelAuraMC:v3_openjdkfrom
alexytomi:v3_openjdk
Closed

fix[MinecraftDownloader]: Better handling in local profile while online#18
alexytomi wants to merge 0 commit into
AngelAuraMC:v3_openjdkfrom
alexytomi:v3_openjdk

Conversation

@alexytomi

@alexytomi alexytomi commented Jun 21, 2025

Copy link
Copy Markdown
Member

This used to throw the exception below after swapping to MainActivity as the launcher prepares to launch java and thus the game

}catch(IOException e) {
throw new RuntimeException("Can't find the source version for "+ versionName +" (req version="+customVer.inheritsFrom+")");

This resulted in a confusing error box. The PR just triggers that but earlier so we catch it and provide a nicer error box.

@crystall1nedev

Copy link
Copy Markdown
Member

This PR does not build, see Actions for more info.

@alexytomi

alexytomi commented Jun 22, 2025

Copy link
Copy Markdown
Member Author

This PR does not build, see Actions for more info.

I forced push a fix but for some reason that didn't retrigger the thing. The issue was a missing import.

@alexytomi

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants