fix[MinecraftDownloader]: Better handling in local profile while online#18
Closed
alexytomi wants to merge 0 commit into
Closed
fix[MinecraftDownloader]: Better handling in local profile while online#18alexytomi wants to merge 0 commit into
alexytomi wants to merge 0 commit into
Conversation
Member
|
This PR does not build, see Actions for more info. |
Member
Author
I forced push a fix but for some reason that didn't retrigger the thing. The issue was a missing import. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to throw the exception below after swapping to MainActivity as the launcher prepares to launch java and thus the game
Amethyst-Android/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/Tools.java
Lines 898 to 899 in dcdcdff
This resulted in a confusing error box. The PR just triggers that but earlier so we catch it and provide a nicer error box.