rework(jre_lwjgl3glfw): Mixed LWJGL versions (3.3.3/3.4.1)#229
Merged
Conversation
ad5f3a9 to
95ad24b
Compare
|
bro where is the lwjgl 3.4.1 |
Member
Author
In the PR obv. Look at the commit. |
b86ab97 to
73fb2aa
Compare
ec9a231 to
6be889e
Compare
3.3.3 is compatible enough from past experience, they started making breaking changes after that. Uses https://github.com/AngelAuraMC/lwjgl3/actions/runs/24239834125 and https://github.com/AngelAuraMC/lwjgl3/actions/runs/24239000627 for 3.4.1 and 3.3.3 modules respectively Removed the InfDev mouse stuff because it was moved to the LWJGLX module. Removed jemalloc because we don't have jemalloc natives so it's just useless. Enabled shaderc,vma,spvc,vulkan bindings for Mojang VK and VulkanMod. Cinnabar still has the issue of needing to have the built-in lwjgl classes inside the jar removed else module encapsulation screws it over and it can't access lwjgl.jar classes. [FIXME] Added spirv-cross natives as AAR. Using https://github.com/AngelAuraMC/SPIRV-Cross/actions/runs/24189750259. Should probably be included in lwjgl natives build but lets worry about that another time.
Uses https://github.com/AngelAuraMC/caciocavallo17/actions/runs/24133618071 Co-authored-by: alexytomi <60690056+alexytomi@users.noreply.github.com>
6be889e to
4f5bc35
Compare
MaxJubayerYT
pushed a commit
to CopperLauncher/Copper-Android
that referenced
this pull request
Apr 11, 2026
rework(jre_lwjgl3glfw): Mixed LWJGL versions (3.3.3/3.4.1)
MaxJubayerYT
pushed a commit
to CopperLauncher/Copper-Android
that referenced
this pull request
Apr 11, 2026
rework(jre_lwjgl3glfw): Mixed LWJGL versions (3.3.3/3.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.3.3 is compatible enough from past experience, they started making breaking changes after that.
Removed the InfDev mouse stuff because it was moved to the LWJGLX module.