-
Notifications
You must be signed in to change notification settings - Fork 62
feat(gateway): make request body size configurable via env #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PranavAgarkar07
wants to merge
10
commits into
AnkanMisra:main
Choose a base branch
from
PranavAgarkar07:feat/configurable-body-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3ee492e
fix(web): improve wallet and gateway error messages
PranavAgarkar07 d8b96eb
test(web): add regression tests for x402 error classification
PranavAgarkar07 17e1fdb
fix: remove duplicate test:unit key in package.json
PranavAgarkar07 f290dbe
feat(gateway): make request body size configurable via env
PranavAgarkar07 60a1453
Merge remote-tracking branch 'origin/main' into feat/configurable-bod…
PranavAgarkar07 2538326
fix: guard getMaxBodySize against non-positive values; use it in cach…
PranavAgarkar07 37dffe6
chore: update lockfile after merging main into feat/configurable-body…
PranavAgarkar07 a0484b1
fix: address Codex review — overflow guard, remove unused vitest, doc…
PranavAgarkar07 4506231
fix: lower max request body clamp to 100MB, revert unrelated lockfile…
PranavAgarkar07 66adb49
test: add route-level body size enforcement tests
PranavAgarkar07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,230 @@ | ||
| import { describe, it, expect } from "vitest"; | ||
| import { classifyError } from "./errors"; | ||
|
|
||
| // ── HTTP status + body based classification ────────── | ||
|
|
||
| describe("classifyError via HTTP context", () => { | ||
| it("classifies 400 + chain_id_mismatch as wrong-chain", () => { | ||
| const e = classifyError(null, { | ||
| status: 400, | ||
| bodyText: '{"error":"chain_id_mismatch"}', | ||
| }); | ||
| expect(e.kind).toBe("wrong-chain"); | ||
| expect(e.title).toBe("Wrong network"); | ||
| expect(e.recoverable).toBe(true); | ||
| }); | ||
|
|
||
| it("classifies 400 + invalid_timestamp as expired", () => { | ||
| const e = classifyError(null, { | ||
| status: 400, | ||
| bodyText: '{"error":"invalid_timestamp"}', | ||
| }); | ||
| expect(e.kind).toBe("expired"); | ||
| expect(e.title).toBe("Payment context expired"); | ||
| }); | ||
|
|
||
| it("classifies 400 + unknown error as invalid-signature", () => { | ||
| const e = classifyError(null, { | ||
| status: 400, | ||
| bodyText: '{"error":"something_else"}', | ||
| }); | ||
| expect(e.kind).toBe("invalid-signature"); | ||
| }); | ||
|
|
||
| it("classifies 402 as expired", () => { | ||
| const e = classifyError(null, { status: 402 }); | ||
| expect(e.kind).toBe("expired"); | ||
| }); | ||
|
|
||
| it("classifies 403 as invalid-signature", () => { | ||
| const e = classifyError(null, { | ||
| status: 403, | ||
| bodyText: '{"error":"invalid_signature"}', | ||
| }); | ||
| expect(e.kind).toBe("invalid-signature"); | ||
| expect(e.title).toBe("Signature was rejected"); | ||
| }); | ||
|
|
||
| it("classifies 408 as ai-timeout", () => { | ||
| const e = classifyError(null, { status: 408 }); | ||
| expect(e.kind).toBe("ai-timeout"); | ||
| }); | ||
|
|
||
| it("classifies 409 + nonce_already_used as duplicate-nonce", () => { | ||
| const e = classifyError(null, { | ||
| status: 409, | ||
| bodyText: '{"error":"nonce_already_used"}', | ||
| }); | ||
| expect(e.kind).toBe("duplicate-nonce"); | ||
| expect(e.title).toBe("Signature already used"); | ||
| expect(e.message).toContain("already submitted"); | ||
| }); | ||
|
|
||
| it("classifies 409 + other body as invalid-signature", () => { | ||
| const e = classifyError(null, { | ||
| status: 409, | ||
| bodyText: '{"error":"conflict"}', | ||
| }); | ||
| expect(e.kind).toBe("invalid-signature"); | ||
| }); | ||
|
|
||
| it("classifies 429 as rate-limited", () => { | ||
| const e = classifyError(null, { status: 429 }); | ||
| expect(e.kind).toBe("rate-limited"); | ||
| expect(e.title).toBe("Rate limited"); | ||
| }); | ||
|
|
||
| it("classifies 502 + verification_unavailable as verifier-unavailable", () => { | ||
| const e = classifyError(null, { | ||
| status: 502, | ||
| bodyText: '{"error":"verification_unavailable"}', | ||
| }); | ||
| expect(e.kind).toBe("verifier-unavailable"); | ||
| expect(e.title).toBe("Verifier unavailable"); | ||
| }); | ||
|
|
||
| it("classifies 502 + upstream_unavailable as ai-unavailable", () => { | ||
| const e = classifyError(null, { | ||
| status: 502, | ||
| bodyText: '{"error":"upstream_unavailable"}', | ||
| }); | ||
| expect(e.kind).toBe("ai-unavailable"); | ||
| expect(e.title).toBe("AI provider unavailable"); | ||
| }); | ||
|
|
||
| it("classifies 504 + verifier_timeout as verifier-timeout", () => { | ||
| const e = classifyError(null, { | ||
| status: 504, | ||
| bodyText: '{"error":"verifier_timeout"}', | ||
| }); | ||
| expect(e.kind).toBe("verifier-timeout"); | ||
| expect(e.title).toBe("Verifier timed out"); | ||
| }); | ||
|
|
||
| it("classifies 504 + upstream_timeout as ai-timeout", () => { | ||
| const e = classifyError(null, { | ||
| status: 504, | ||
| bodyText: '{"error":"upstream_timeout"}', | ||
| }); | ||
| expect(e.kind).toBe("ai-timeout"); | ||
| expect(e.title).toBe("AI provider timed out"); | ||
| }); | ||
|
|
||
| it("classifies 5xx unknown as ai-unavailable", () => { | ||
| const e = classifyError(null, { status: 503 }); | ||
| expect(e.kind).toBe("ai-unavailable"); | ||
| }); | ||
|
|
||
| it("classifies unknown status as unknown", () => { | ||
| const e = classifyError(null, { status: 418 }); | ||
| expect(e.kind).toBe("unknown"); | ||
| }); | ||
| }); | ||
|
|
||
| // ── Error object based classification ─────────────── | ||
|
|
||
| describe("classifyError via thrown Error", () => { | ||
| it("classifies user rejection by code 4001", () => { | ||
| const e = classifyError({ code: 4001, message: "User rejected" }); | ||
| expect(e.kind).toBe("user-rejected"); | ||
| expect(e.title).toBe("You cancelled the signature"); | ||
| expect(e.recoverable).toBe(true); | ||
| }); | ||
|
|
||
| it("classifies user rejection by ACTION_REJECTED", () => { | ||
| const e = classifyError({ code: "ACTION_REJECTED", message: "MetaMask rejection" }); | ||
| expect(e.kind).toBe("user-rejected"); | ||
| }); | ||
|
|
||
| it("classifies user rejection by message text", () => { | ||
| const e = classifyError(new Error("user rejected the request")); | ||
| expect(e.kind).toBe("user-rejected"); | ||
| }); | ||
|
|
||
| it("classifies wrong chain by message text", () => { | ||
| const e = classifyError(new Error("Wrong network. Please switch to Base Sepolia")); | ||
| expect(e.kind).toBe("wrong-chain"); | ||
| }); | ||
|
|
||
| it("classifies wrong chain by 'did not switch' message", () => { | ||
| const e = classifyError(new Error("Wallet did not switch to chain 84532")); | ||
| expect(e.kind).toBe("wrong-chain"); | ||
| }); | ||
|
|
||
| it("classifies missing wallet", () => { | ||
| const e = classifyError(new Error("No crypto wallet found")); | ||
| expect(e.kind).toBe("no-wallet"); | ||
| expect(e.recoverable).toBe(false); | ||
| }); | ||
|
|
||
| it("classifies network fetch error", () => { | ||
| const e = classifyError(new TypeError("Failed to fetch")); | ||
| expect(e.kind).toBe("network"); | ||
| }); | ||
|
|
||
| it("classifies network error by message", () => { | ||
| const e = classifyError(new Error("NetworkError: connection refused")); | ||
| expect(e.kind).toBe("network"); | ||
| }); | ||
|
|
||
| it("classifies unknown error as unknown", () => { | ||
| const e = classifyError(new Error("Something unexpected happened")); | ||
| expect(e.kind).toBe("unknown"); | ||
| expect(e.title).toBe("Something broke"); | ||
| }); | ||
|
|
||
| it("handles non-object err gracefully", () => { | ||
| const e = classifyError("string error"); | ||
| expect(e.kind).toBe("unknown"); | ||
| }); | ||
|
|
||
| it("handles null err gracefully", () => { | ||
| const e = classifyError(null); | ||
| expect(e.kind).toBe("unknown"); | ||
| }); | ||
| }); | ||
|
|
||
| // ── Detail sanitization ───────────────────────────── | ||
|
|
||
| describe("sanitizeDetail via classified errors", () => { | ||
| it("extracts clean error code from gateway JSON", () => { | ||
| const e = classifyError(null, { | ||
| status: 403, | ||
| bodyText: '{"error":"invalid_signature","correlation_id":"rc_abc123"}', | ||
| }); | ||
| expect(e.detail).toBe("[invalid_signature] correlation_id=rc_abc123"); | ||
| }); | ||
|
|
||
| it("extracts error code without correlation_id", () => { | ||
| const e = classifyError(null, { | ||
| status: 409, | ||
| bodyText: '{"error":"nonce_already_used"}', | ||
| }); | ||
| expect(e.detail).toBe("[nonce_already_used]"); | ||
| }); | ||
|
|
||
| it("passes through non-JSON body text unchanged", () => { | ||
| const e = classifyError(null, { | ||
| status: 429, | ||
| bodyText: "rate limit exceeded", | ||
| }); | ||
| expect(e.detail).toBe("rate limit exceeded"); | ||
| }); | ||
|
|
||
| it("truncates long non-JSON body", () => { | ||
| const long = "x".repeat(300); | ||
| const e = classifyError(null, { status: 500, bodyText: long }); | ||
| expect(e.detail).toBe("x".repeat(200) + "..."); | ||
| expect(e.detail!.length).toBe(203); | ||
| }); | ||
|
|
||
| it("sets undefined detail when no bodyText", () => { | ||
| const e = classifyError(null, { status: 429 }); | ||
| expect(e.detail).toBeUndefined(); | ||
| }); | ||
|
|
||
| it("uses error.message as detail for thrown errors", () => { | ||
| const e = classifyError(new Error("user rejected the request")); | ||
| expect(e.detail).toBe("user rejected the request"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces a new operator-facing gateway setting, but only
.env.examplementions it; the main README configuration table,gateway/README.mdoptional-variable table, and.env.production.examplestill omit it. In production/setup contexts users will not discover the new limit knob or know its default/unit, so please keep those config references aligned with this new env var.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PranavAgarkar07