test: cover SDK UTF-8 base64 helpers#307
Conversation
|
Someone is attempting to deploy a commit to the ankanmisra's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded TypeScript tests covering UTF-8/base64 round trips, empty and known fixture values, invalid inputs, missing ChangesBase64 helper validation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| ["ASCII", "Hello, world!"], | ||
| ["accented text", "Café déjà vu"], | ||
| ["non-Latin text", "नमस्ते мир"], | ||
| ["emoji", "Paygate 🚀✅"], |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Validation
Fixes #260
Note
Add tests for SDK UTF-8/base64 helper functions
Adds base64.test.ts to cover
encodeUtf8ToBase64anddecodeBase64ToUtf8. Tests include round-trip encoding for ASCII, accented, non-Latin, and emoji strings, a known fixture check, rejection of invalid base64 with a specific error message, and behavior whenatob/btoaglobals are unavailable. AwithoutGlobalhelper temporarily removes and restores named globals during tests.Macroscope summarized 2aff74b.
Summary by CodeRabbit