Skip to content

Add tqdm progress for file indexing #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnth wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add tqdm progress for file indexing #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d410d51
add tqdm for indexing progress
dnth Dec 30, 2024
1f57fbe
update tqdm without formatting
dnth Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions byaldi/colpali.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from colpali_engine.models import ColPali, ColPaliProcessor, ColQwen2, ColQwen2Processor
from pdf2image import convert_from_path
from PIL import Image
from tqdm.auto import tqdm

from byaldi.objects import Result

Expand Down Expand Up @@ -357,8 +358,7 @@ def index(
raise ValueError(
f"Number of metadata entries ({len(metadata)}) does not match number of documents ({len(items)})"
)
for i, item in enumerate(items):
print(f"Indexing file: {item}")
for i, item in enumerate(tqdm(items, desc="Indexing files")):
doc_id = doc_ids[i] if doc_ids else self.highest_doc_id + 1
doc_metadata = metadata[doc_id] if metadata else None
self.add_to_index(
Expand Down Expand Up @@ -741,4 +741,4 @@ def encode_query(self, query: Union[str, List[str]]) -> torch.Tensor:
return embeddings.cpu()

def get_doc_ids_to_file_names(self):
return self.doc_ids_to_file_names
return self.doc_ids_to_file_names