Skip to content

Improve error message raised when exporting relative import in notebook. #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jph00 merged 2 commits into from
Apr 22, 2026
+2 −2
Merged

Improve error message raised when exporting relative import in notebook. #1590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c522869
explicit error message when exporting with relative import
dienhoa Apr 21, 2026
77a0636
remove metadata diff
dienhoa Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nbdev/maker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def make_code_cells(*ss): return dict2nb({'cells':L(ss).map(mk_cell)}).cells
# %% ../nbs/api/02_maker.ipynb #a2546836
def relative_import(name, fname, level=0):
"Convert a module `name` to a name relative to `fname`"
assert not level
if level: raise ValueError(f"nbdev export does not support relative imports: module={name}, export_path={fname}")
sname = name.replace('.','/')
if not(os.path.commonpath([sname,fname])): return name
rel = os.path.relpath(sname, fname)
Expand Down
2 changes: 1 addition & 1 deletion nbs/api/02_maker.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@
"#| export\n",
"def relative_import(name, fname, level=0):\n",
" \"Convert a module `name` to a name relative to `fname`\"\n",
" assert not level\n",
" if level: raise ValueError(f\"nbdev export does not support relative imports: module={name}, export_path={fname}\")\n",
" sname = name.replace('.','/')\n",
" if not(os.path.commonpath([sname,fname])): return name\n",
" rel = os.path.relpath(sname, fname)\n",
Expand Down
Loading